-
Notifications
You must be signed in to change notification settings - Fork 339
Support Laravel 8 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support Laravel 8 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngunyimacharia
commented
Sep 12, 2020
Hope this gets merged soon
patrickomeara
commented
Sep 16, 2020
I can confirm this is working with Laravel 8. I am using the fork in production.
amdadulhoque
commented
Sep 20, 2020
It should be merge. It's working perfectly with Laravel-8
Great, thank you! I'll take a look today.
Also, I wish the build wasn't so flaky. We have to see why the build is failing and do the appropriate changes.
Additionally, need to update the readme to reflect the new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This contains breaking changes (
QueryBuilder::cleanBindingsis now public), so needs to be released as a new major version (4.0).