Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: align previous/next page flag with relay standard #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcleonard wants to merge 1 commit into graphql:main
base: main
Choose a base branch
Loading
from tcleonard:tcleonard/fix-pagination

Conversation

@tcleonard
Copy link

@tcleonard tcleonard commented Sep 5, 2022
edited
Loading

Fix issue #286 and #58

robinpdm, lucas-bremond, leejacobson, and MasahikoYonezawa reacted with thumbs up emoji
Copy link

linux-foundation-easycla bot commented Sep 5, 2022
edited
Loading

CLA Missing ID CLA Not Signed

Copy link
Author

@Cito the goal of this MR is to align the computation of the page info with the relay official spec.
Indeed the computation of the "has previous/next page" flags was not matching what is defined in the documentation.
I have added unit tests for the missing cases.
Since the standard definition can return unexpected result in some cases I left some comment to make that very explicit that it is not a bug.

Copy link
Member

Cito commented Sep 12, 2022

@tcleonard Thanks, but I'm not maintaining graphql-relay-js. Maybe @IvanGoncharov can look into this? If it gets merged, I will gladly port it over to graphql-relay-py.

tcleonard reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /