-
Notifications
You must be signed in to change notification settings - Fork 179
fix: align previous/next page flag with relay standard #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- ❌ The commit (d7f07fb). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
tcleonard
commented
Sep 5, 2022
@Cito the goal of this MR is to align the computation of the page info with the relay official spec.
Indeed the computation of the "has previous/next page" flags was not matching what is defined in the documentation.
I have added unit tests for the missing cases.
Since the standard definition can return unexpected result in some cases I left some comment to make that very explicit that it is not a bug.
Cito
commented
Sep 12, 2022
@tcleonard Thanks, but I'm not maintaining graphql-relay-js. Maybe @IvanGoncharov can look into this? If it gets merged, I will gladly port it over to graphql-relay-py.
3a9195c to
d7f07fb
Compare
Uh oh!
There was an error while loading. Please reload this page.
Fix issue #286 and #58