Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issue #520 exposed event hooks onEditQuery + onEditVariables on Playg... #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arush wants to merge 1 commit into graphql:main
base: main
Choose a base branch
Loading
from arush:feature/onedit-event-hooks

Conversation

@arush
Copy link

@arush arush commented Sep 3, 2018

exposed event hooks onEditQuery + onEditVariables on Playground component and updated demo

Fixes #520

Changes proposed in this pull request:

  • ability to hook into edit events of <Playground/>

  • updated demo demonstrating url update on query and variables edit

naishe reacted with thumbs up emoji
...n Playground component and updated demo
Copy link

CLAassistant commented Sep 3, 2018
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Arush Sehgal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Author

arush commented Sep 3, 2018

I'm not sure what the vision of the project is for this but even just having this basic functionality goes a long way for removing our dependence on GraphiQL - especially considering the share functionality doesn't work (see #793 )

This is a non-breaking change, people are free to use or not use these event hooks as they wish so I would appreciate if this was merged independent of whatever the vision of the project is for sharing Playground state.

Copy link

@arush sign the licence

Copy link
Collaborator

huv1k commented Oct 15, 2018

Hey @arush, can you please sign license? I will merge it then :) Thx

Copy link
Author

arush commented Oct 13, 2019

Sorry I don’t know how, GitHub won’t let me. Feel free to use my code though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Add events to properties for example onEditQuery, onEditVariables

AltStyle によって変換されたページ (->オリジナル) /