-
Couldn't load subscription status.
- Fork 732
Issue #520 exposed event hooks onEditQuery + onEditVariables on Playg... #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...n Playground component and updated demo
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Arush Sehgal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
I'm not sure what the vision of the project is for this but even just having this basic functionality goes a long way for removing our dependence on GraphiQL - especially considering the share functionality doesn't work (see #793 )
This is a non-breaking change, people are free to use or not use these event hooks as they wish so I would appreciate if this was merged independent of whatever the vision of the project is for sharing Playground state.
regisbsb
commented
Sep 21, 2018
@arush sign the licence
Hey @arush, can you please sign license? I will merge it then :) Thx
Sorry I don’t know how, GitHub won’t let me. Feel free to use my code though
exposed event hooks onEditQuery + onEditVariables on Playground component and updated demo
Fixes #520
Changes proposed in this pull request:
ability to hook into edit events of
<Playground/>updated demo demonstrating url update on query and variables edit