Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: (WIP) Upgrade webpack and other dependencies #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
binoy14 wants to merge 3 commits into graphql:main
base: main
Choose a base branch
Loading
from binoy14:binoy14/webpack-upgrade
Draft

chore: (WIP) Upgrade webpack and other dependencies #1195

binoy14 wants to merge 3 commits into graphql:main from binoy14:binoy14/webpack-upgrade

Conversation

@binoy14
Copy link
Contributor

@binoy14 binoy14 commented Apr 7, 2020

Fixes #.
Electron Build

Changes proposed in this pull request:

Copy link

CLAassistant commented Apr 7, 2020
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ acao
❌ binoy14
You have signed the CLA already but the status is still pending? Let us recheck it.

@binoy14 binoy14 changed the title (削除) (WIP) Upgrade webpack and other dependencies (削除ここまで) (追記) chore: (WIP) Upgrade webpack and other dependencies (追記ここまで) Apr 7, 2020
mode: 'development',
entry: './src/renderer',
target: 'electron',
target: 'electron-main',
Copy link
Member

@acao acao Apr 7, 2020
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want electron-renderer here. electron-main is the node runtime, where as electron-render is chromium

binoy14 reacted with thumbs up emoji
Copy link
Member

acao commented May 5, 2020

@binoy14 is electron building here yet? I might come by and check it out this weekend

Copy link
Contributor Author

binoy14 commented May 5, 2020

@acao no, I couldn't get it to build. Help would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acao acao acao left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /