-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: shared type excluded from non-first project caches #4107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚠️ No Changeset found
Latest commit: 281a489
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
- ✅login: smpanaro / name: Stephen Panaro / (281a489)
The committers listed above are authorized under a signed CLA.
This propagates the project when populating the cache.
For a config like this:
If
shared.graphqlcontains a type used in both./public/documents.graphqland./private/documents.graphql, the cache will only be populated for the first project (public here). This causes features like "go to definition" to only work for that project.Propagating the project adds the shared types to the cache for both projects, and makes "go to definition" work for both.
Example Project