-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CDN Example: Add integrity metadata map and SRI hashes + Github Action to update #4100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚠️ No Changeset found
Latest commit: d3f1bb6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Holy crap thank you, I was so frustrated trying to put this together myself when trying to integrate GraphiQL into my app where I use SRI for everything else. I hope this gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @magicmark!
43b3805 to
9c3118d
Compare
Uh oh!
There was an error while loading. Please reload this page.
This reference implementation will likely be copied and pasted in a bunch of places.
SRI hashes are important when loading from CDNs, so hopefully this improves security in a bunch of places :)
(I've verified manually this file still works)
I've also set up a github action to regenerate the example when:
releasedaction for updated internal deps