-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[vscode-graphql-syntax] Add support for GraphQL embedded in Hack files #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 261039b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary: This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README. Test Plan: - `yarn test -u` from package root - `yarn vsce:package` and install resulting VSIX - Load `test.hack` in VS Code - Observe nice syntax highlighting for GraphQL
Summary: This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README. Test Plan: - `yarn test -u` from package root - `yarn vsce:package` and install resulting VSIX - Load `test.hack` in VS Code - Observe nice syntax highlighting for GraphQL
bf7c039 to
db77a2c
Compare
@acao apologies for my GitHub noobiness, but does your force push mean this will be released? If not, is there anything I need to do to get this over the line? Thanks in advance :)
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.96%. Comparing base (0d9e51a) to head (eb3b6ae).
Additional details and impacted files
@@ Coverage Diff @@ ## main #3872 +/- ## ======================================= Coverage 63.96% 63.96% ======================================= Files 35 35 Lines 3086 3086 Branches 948 949 +1 ======================================= Hits 1974 1974 Misses 1107 1107 Partials 5 5
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Uh oh!
There was an error while loading. Please reload this page.
Summary:
This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README.
Test Plan:
yarn test -ufrom package rootyarn vsce:packageand install resulting VSIXtest.hackin VS CodeScreenshot 2025年03月04日 at 10 07 57 AM