Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update SwiftChart with Animations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
norfred wants to merge 6 commits into gpbl:master
base: master
Choose a base branch
Loading
from norfred:master
Open

Conversation

@norfred
Copy link

@norfred norfred commented Jun 25, 2015

  • Introducing animations both for Series and Areas, w/ related delegate's method
  • Fixed a problem with identities signing (maybe it was just me?)
  • Refreshed UI
  • Better files organization

Manfredi and others added 6 commits June 25, 2015 22:08 
- Introducing animation both for Series and Areas, w/ related delegate's method
- Fixed a problem with identities signing
- Refreshed UI
- Better files organization
@norfred norfred mentioned this pull request Jun 25, 2015
Copy link
Owner

gpbl commented Jul 1, 2015

@norfred thanks for the PR, and sorry for the late answer 😅

  • I'm not sure about the animation regarding the negative areas, i believe that was the main reason I didn't implement it for the first release. The animation should consider a serie as an unique line, while now the line is split in different segments:
- I'd better animate the areas by sliding them from left to right instead of fading them in. This also may require to complicate the code a bit. - I'm not for adding new methods to the delegate: instead, i'd keep the setting for the animation duration in the `ChartSerie` class, as it happens for the appearance. I wonder though if it is really needed: isn't the `animationDuration` in the main class enough? I can't see a case where a dev would need different values for each serie.

Copy link
Owner

gpbl commented Jul 1, 2015

Oh i just realized in #3 i was opting for animating a mask over the chart. Maybe this could work better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /