Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Update README.md #185

Merged
samtstern merged 1 commit into googlesamples:master from dcgavril:patch-1
Dec 11, 2017
Merged

Update README.md #185

samtstern merged 1 commit into googlesamples:master from dcgavril:patch-1
Dec 11, 2017

Conversation

@dcgavril
Copy link
Contributor

@dcgavril dcgavril commented Dec 9, 2017

The method that is annotated with AfterPermissionGranted needs to be void and without input parameters so that it can be invoked, as it can create unwanted crashes on permissions granted - EasyPermissions.java line 408 and issue #169.

The method that is annotated with `AfterPermissionGranted` needs to be void and without input parameters so that it can be invoked, as it can create unwanted crashes on permissions granted - EasyPermissions.java line 408 and issue googlesamples#169.
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Copy link
Contributor Author

dcgavril commented Dec 9, 2017

I signed it!

Copy link

CLAs look good, thanks!

Copy link
Contributor

@dcgavril thank you for the contribution!

dcgavril reacted with thumbs up emoji

@samtstern samtstern merged commit fd4d351 into googlesamples:master Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /