Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

NF: correct markdown #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnorbye merged 1 commit into googlesamples:main from Arthur-Milchior:main
Sep 9, 2021
Merged

NF: correct markdown #54

tnorbye merged 1 commit into googlesamples:main from Arthur-Milchior:main
Sep 9, 2021

Conversation

@Arthur-Milchior
Copy link
Contributor

@Arthur-Milchior Arthur-Milchior commented Jul 31, 2021

Github breaks link if [] and () are on distinct lines; in order for link to
works, your formatting was wrong.

Also, LICENCE and CONTRIBUTING.md should be link to the file

Compare https://github.com/Arthur-Milchior/android-custom-lint-rules/blob/main/CONTRIBUTING.md and https://github.com/googlesamples/android-custom-lint-rules/blob/main/CONTRIBUTING.md to see the difference

Copy link

google-cla bot commented Jul 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

i️ Googlers: Go here for more info.

Github breaks link if [] and () are on distinct lines; in order for link to
works, your formatting was wrong.
Also, LICENCE and CONTRIBUTING.md should be link to the file
Copy link

google-cla bot commented Jul 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

i️ Googlers: Go here for more info.

Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor Author

And no, it's not my first contribution to Google open source. It's only my first as a xoogler

@tnorbye tnorbye merged commit a184950 into googlesamples:main Sep 9, 2021
Copy link
Collaborator

tnorbye commented Sep 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /