-
Notifications
You must be signed in to change notification settings - Fork 174
Corrected issue-message. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
commented
Sep 1, 2015
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
I signed it!
googlebot
commented
Sep 1, 2015
CLAs look good, thanks!
Thanks for the correction.
tnorbye
added a commit
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all many thanks for publishing an official project for custom Lint rules. 👍🏻
I just noticed a minor issue. There was a misleading
issue messageif the manifest contains no<activity>tag. It states "[...] AndroidManifest.xml to have an tag [...]". But it's only looking for<activity>. Even if you add an<application>tag to the manifest intestMissingApplication()thisIssueis still reported. So I assume it's an error.I fixed the message and the test case accordingly.
(I furthermore replaced
EnumSet.of(Scope.MANIFEST)with the corresponding constantScope.MANIFEST_SCOPEwhich is more readable IMHO).