-
Couldn't load subscription status.
- Fork 104
Add support for rubocop formatter #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
0bff7d7 to
542d72d
Compare
@googlebot I signed it!
CLAs look good, thanks!
i️ Googlers: Go here for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you see about adding a vroom test file with examples of rubocop's expected input/outputs, like other formatters have under the vroom/ directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatted[1:] is a little strange... does the formatter output an extra first line to stdout that's not part of the output?
Signed-off-by: Ari Archer <truncateddinosour@gmail.com>
Is anyone still working on this? I was about to start doing this when I found it already done and pending review.
Is anyone still working on this? I was about to start doing this when I found it already done and pending review.
I suspect that David was waiting for a response to his question. If you want to take over and send a new PR that is reasonable
Note: This change is based on an abandoned change by zinovyev #132
This pull request adds a rubocop support for Ruby and ERuby file types.
Solves #30