high

The handling of default values for Enum parameters is incorrect and will lead to a ValueError.

There are two issues with the current implementation:

1. The _is_default_value_compatible function does not support Enum types and will always return False, causing an exception to be raised on line 154 if a default value is present.
2. On line 155, schema.default is assigned the Enum member itself (param.default) instead of its value. Since the schema type is STRING, the default value should also be a string (i.e., param.default.value).

The suggested change below fixes both problems by performing the compatibility check locally and ensuring the correct value is assigned to schema.default.

This is due to reason that the default value get wipped of by this function

As per this PR Gemini API now supports default value, hence commented the above function

medium

The new test for enums only covers the basic case without a default value. To ensure the implementation is robust and to prevent regressions, it's important to add test cases for function parameters with default values. This would have helped catch the bug with default value handling in the current implementation.

Please consider adding tests for the following scenarios:

• A valid default value provided as an enum member (e.g., param: MyEnum = MyEnum.VALUE).
• A valid default value provided as a raw value (e.g., param: MyEnum = 'value').
• An invalid default value, which should raise a ValueError.

Here's an example of how you could structure these tests:

import pytest
def test_enum_with_default_member():
 class InputEnum(Enum):
 AGENT = "agent"
 TOOL = "tool"
 def simple_function(input: InputEnum = InputEnum.AGENT):
 return input.value
 function_decl = _automatic_function_calling_util.build_function_declaration(
 func=simple_function
 )
 assert function_decl.parameters.properties['input'].default == 'agent'
def test_enum_with_invalid_default():
 class InputEnum(Enum):
 AGENT = "agent"
 TOOL = "tool"
 def simple_function(input: InputEnum = "invalid_default"):
 return input.value
 with pytest.raises(ValueError):
 _automatic_function_calling_util.build_function_declaration(
 func=simple_function
 )

Added test cases for default value as well as invalid value