-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Fix issue with MCP tools throwing an error. #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @nickvander, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug that prevented MCP tools from correctly processing schemas containing array types. Previously, if an array was defined without an explicit Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Response from ADK Triaging Agent
Hello @nickvander, thank you for creating this PR!
To help us review this bug fix efficiently, could you please provide the following information based on our contribution guidelines?
- Associated Issue: Please create and link a GitHub issue that this PR addresses.
- Testing Plan: Could you add a
testing plansection to your PR description explaining how you've tested these changes? - Verification: It would be helpful to include logs or screenshots demonstrating the fix in action.
You can find more details in our contribution guidelines. Thanks!
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where MCP tools would error on schemas with array types that were missing an items field. The change correctly adds a default items field. However, the implementation introduces some code duplication. My review includes a suggestion to refactor the code to remove this duplication, which will improve the long-term maintainability of this function.
ac4e6a9 to
33b2d49
Compare
Uh oh!
There was an error while loading. Please reload this page.
Problem
When an MCP tool is resolved using _gemini_schema_util.py, if it has an array it wasn't correctly resolving them and showing an error:
GenerateContentRequest.tools[0].function_declarations[1].parameters.properties[segmentation_classes].items: missing field
Root Cause
The error "parameters.properties[segmentation_classes].items: missing field" indicates _to_gemini_schema isn't correctly handling array types.
Implementation Details
Correctly handle array types by adding a default items field of {"type": "string"} to schemas with type: array but no items field.
Fixes: #3082