Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Feat/expose mcps streamable http custom httpx factory parameter #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeedjones wants to merge 17 commits into google:main
base: main
Choose a base branch
Loading
from mikeedjones:feat/expose-mcps-streamable-http-custom-httpx-factory-parameter

Conversation

@mikeedjones
Copy link

@mikeedjones mikeedjones commented Sep 22, 2025 •
edited
Loading

This PR addresses #3005 and #2963 to allow control over the ssl cert used when connecting to an mcp server by exposing the httpx_client_factory parameter exposed when creating a MCPSessionManager in adk. Overlaps with #2966 but I don't believe that that PR's implementation will work. streamablehttp_client needs a client factory, not a client.

testing plan

Adds test checking that streamablehttp_client uses the custom httpx factory. Could also test that a factory which obeys the McpHttpClientFactory protocol produces valid behavior when the session is opened?

related issues

#2227 and #2881 both request slightly different options to control the ssl certs used internally by adk. I think exposing a httpx factory is a good pattern which could be followed for those issues too.

EFord36, stelong, alessiosarullo, martina-zxy, tmorgansl, MDUK0001, and lucabaronti reacted with thumbs up emoji
Copy link

google-cla bot commented Sep 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Summary of Changes

Hello @mikeedjones, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the MCPSessionManager by enabling the injection of a custom httpx_client_factory. This allows developers to fully customize the underlying HTTP client used for interactions with MCP servers, providing flexibility for advanced configurations such as specific SSL certificate management or proxy settings, thereby addressing existing requests for more control over internal ADK HTTP client behavior.

Highlights

  • Custom HTTP Client Factory Exposure: The MCPSessionManager now exposes an httpx_client_factory parameter, allowing users to provide a custom factory for creating httpx clients.
  • Enhanced HTTP Client Control: This change provides more granular control over the HTTP client used for connecting to MCP servers, addressing needs like custom SSL certificate handling or other advanced HTTP client configurations.
  • New Test Coverage: A new test case has been added to ensure that the custom httpx_client_factory is correctly invoked when initializing an MCPSessionManager.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@adk-bot adk-bot added bot triaged mcp [Component] Issues about MCP support labels Sep 22, 2025
Copy link
Collaborator

adk-bot commented Sep 22, 2025

Response from ADK Triaging Agent

Hello @mikeedjones, thank you for your contribution!

To help our reviewers, could you please add a testing plan section to your PR description? This section should briefly describe how you've tested the changes.

You can find more details in our contribution guidelines. Thanks!

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully exposes the httpx_client_factory parameter for StreamableHTTPConnectionParams, allowing for greater control over the internal httpx client. The implementation is clean and the inclusion of a test case is appreciated. I've provided a couple of minor suggestions to improve code style and align the new test with unit testing best practices.

@mikeedjones mikeedjones force-pushed the feat/expose-mcps-streamable-http-custom-httpx-factory-parameter branch from 5b70475 to 8ab74cc Compare September 22, 2025 17:42
@mikeedjones mikeedjones force-pushed the feat/expose-mcps-streamable-http-custom-httpx-factory-parameter branch from 8ab74cc to a1fcb65 Compare September 23, 2025 08:19 
... test_init_with_streamable_http_default_httpx_factory for clarity
Copy link

@mikeedjones Thanks for opening this! I'm going to close mine as this seems like a better implementation.
mikeedjones reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanzhou1023 seanzhou1023 Awaiting requested review from seanzhou1023

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

mcp [Component] Issues about MCP support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /