-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Enable injection of httpx client factory for streamable-http mcp client #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable injection of httpx client factory for streamable-http mcp client #2996
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Summary of ChangesHello @mikeedjones, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Response from ADK Triaging Agent
Hello @mikeedjones, thank you for creating this PR!
To help us review this pull request, could you please:
- Sign our Contributor License Agreement (CLA).
- Include a
testing plansection in your PR to describe how you tested these changes.
This information will help reviewers to review your PR more efficiently. Thanks!
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature by allowing the injection of an httpx client factory for the streamable HTTP MCP client. This enhances flexibility, particularly for managing SSL certificates. The implementation is clean and follows existing patterns. My main feedback is to add unit tests to cover this new functionality to ensure its correctness and prevent future regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the addition of httpx_client_factory is a great feature for customizability, the pull request seems to be missing corresponding unit tests. It would be beneficial to add tests to tests/unittests/tools/mcp_tool/test_mcp_session_manager.py to ensure that:
StreamableHTTPConnectionParamscan be initialized correctly with thehttpx_client_factory.- The
_create_clientmethod correctly passes the factory to thestreamablehttp_client.
Adding these tests will help verify the new functionality and prevent future regressions.
PiperOrigin-RevId: 809270320
bb4caa6 to
e6c5820
Compare
#2227 and #2881 both request slightly different options to control the ssl certs used internally by adk.
This PR addresses a related but distinct case of control over the ssl cert used when connecting to an mcp server by exposing the
httpx_client_factoryparameter exposed when creating aMCPSessionManagerin adk.