feat: full async implementation of DatabaseSessionService #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

GitMarco27 wants to merge 4 commits into google:main

from GitMarco27:feature/async_database_session_service

Open

feat: full async implementation of DatabaseSessionService #2889

GitMarco27 wants to merge 4 commits into google:main from GitMarco27:feature/async_database_session_service

Conversation

@GitMarco27

Copy link

@GitMarco27 GitMarco27 commented Sep 9, 2025

Implement Full async DatabaseSessionService

Target Issue: #1005

Overview

This PR introduces an asynchronous implementation of the DatabaseSessionService with minimal breaking changes. The primary goal is to enable effective use of ADK in fully async environments and API endpoints while avoiding event loop blocking during database I/O operations.

Changes

Converted DatabaseSessionService to use async/await patterns throughout

Testing Plan

The implementation has been tested following the project's contribution guidelines:

Unit Tests

All existing unit tests pass successfully
Minor update to test requirements added to support aiosqlite

Manual End-to-End Testing

E2E tests performed using:
- LLM Provider: LiteLLM
- Database: PostgreSQL with asyncpg driver

from google.adk.sessions.database_session_service import DatabaseSessionService
connection_string: str = (
 "postgresql+asyncpg://PG_USER:PG_PSWD@PG_HOST:5432/PG_DB"
)
session_service: DatabaseSessionService = DatabaseSessionService(
 db_url=connection_string
)
session = await session_service.create_session(
 app_name="test_app", session_id="test_session", user_id="test_user"
)
assert session is not None
sessions = await session_service.list_sessions(app_name="test_app", user_id="test_user")
assert len(sessions.sessions) > 0
session = await session_service.get_session(
 app_name="test_app", session_id="test_session", user_id="test_user"
)
assert session is not None
await session_service.delete_session(
 app_name="test_app", session_id="test_session", user_id="test_user"
)
assert (
 await session_service.get_session(
 app_name="test_app", session_id="test_session", user_id="test_user"
 )
 is None
)

The implementation have been also tested using the following configurations for llm provider and Runner:

def get_azure_openai_model(deployment_id: str | None = None) -> LiteLlm:
 ...
 if not deployment_id:
 deployment_id = os.getenv("AZURE_OPENAI_DEPLOYMENT_ID")
 logger.info(f"Using Azure OpenAI deployment ID: {deployment_id}")
 return LiteLlm(
 model=f"azure/{os.getenv('AZURE_OPENAI_DEPLOYMENT_ID')}",
 stream=True,
 )
...
 @staticmethod
 def _get_runner(agent: Agent) -> Runner:
 storage=DatabaseSessionService(db_url=get_pg_connection_string())
 return Runner(
 agent=agent,
 app_name=APP_NAME,
 session_service=storage,
 )
...
async for event in self.runner.run_async(
 user_id=user_id,
 session_id=session_id,
 new_message=content,
 run_config=(
 RunConfig(
 streaming_mode=StreamingMode.SSE, response_modalities=["TEXT"]
 )
 if stream
 else RunConfig()
 ),
):
 last_event = event
 if stream:
 yield event
...

Breaking Changes

Database connection string format may need updates for async drivers

@GitMarco27


 feat: full async implementatio nof DatabaseSessionService

bcf7aef

gemini-code-assist[bot]

gemini-code-assist bot reviewed

Sep 9, 2025

View reviewed changes

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @GitMarco27, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive asynchronous implementation for the DatabaseSessionService. The primary motivation is to facilitate the effective use of the ADK in fully asynchronous environments and API endpoints, specifically by preventing event loop blocking during database I/O operations. This change significantly enhances the service's compatibility and performance in modern async Python applications.

Highlights

Asynchronous DatabaseSessionService: The DatabaseSessionService has been fully converted to use asynchronous patterns, enabling non-blocking database I/O operations in async environments.
Lazy Table Creation: Database tables are now created lazily upon the first database interaction, rather than during service initialization, improving startup performance.
Dependency Update: The aiosqlite library has been added as a test dependency to support asynchronous SQLite connections.
Minimal Breaking Changes: The implementation aims for minimal breaking changes, primarily affecting database connection string formats for async drivers.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@adk-bot adk-bot added bot triaged services labels

Sep 9, 2025

@adk-bot adk-bot requested a review from DeanChensj

September 9, 2025 14:22

gemini-code-assist[bot]

gemini-code-assist bot reviewed

Sep 9, 2025

View reviewed changes

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of converting the DatabaseSessionService to a fully asynchronous implementation. The changes correctly adopt async/await patterns and modern SQLAlchemy 2.0 style for async operations, which will significantly benefit applications running in an async environment. The code is clean and the approach of lazy table creation is sound. I've found one potential race condition in the table creation logic and provided a detailed suggestion to resolve it using an asyncio.Lock. With that fix, this will be a solid enhancement.

src/google/adk/sessions/database_session_service.py Outdated Show resolved Hide resolved

@GitMarco27


 fix: implement thread-safe creation in DatabaseSessionService

ebf7ec3

@GitMarco27

Copy link

Author

GitMarco27 commented Sep 9, 2025 •

edited

Loading

@gemini-code-assist review

gemini-code-assist[bot]

gemini-code-assist bot reviewed

Sep 9, 2025

View reviewed changes

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does an excellent job of converting the DatabaseSessionService to a fully asynchronous implementation. The changes correctly adopt sqlalchemy.ext.asyncio patterns, including the use of an async engine, async sessions, and the modern select statement syntax. The introduction of lazy, thread-safe table creation via _ensure_tables_created is a robust addition. My review focuses on performance optimizations, suggesting the use of asyncio.gather to run independent database queries concurrently, which should reduce latency in several key methods. Overall, this is a high-quality and well-executed feature implementation.

src/google/adk/sessions/database_session_service.py Show resolved Hide resolved

@GitMarco27 GitMarco27 changed the title ~~(削除) feat: full async implementatio nof DatabaseSessionService (削除ここまで)~~ (追記) feat: full async implementation of DatabaseSessionService (追記ここまで)

Sep 9, 2025

GitMarco27 added 2 commits

September 11, 2025 17:04

@GitMarco27


 Merge branch 'main' into feature/async_database_session_service

000940b

@GitMarco27


 Merge branch 'main' into feature/async_database_session_service

e1b1b14

@iborko

Copy link

iborko commented Sep 30, 2025

@DeanChensj can you prioritize this? Database session service is very important component for production of the systems based on ADK, it's a real shame this part is still sync.

@boyangsvl boyangsvl removed the bot triaged label

Oct 8, 2025

@matthiasak

Copy link

matthiasak commented Oct 9, 2025

+1 here -- this is a mission critical feature

@fabiofumarola

Copy link

fabiofumarola commented Oct 9, 2025

really waiting to see it integrated!

@mikeedjones

Copy link

mikeedjones commented Oct 14, 2025 •

edited

Loading

Thank you @GitMarco27 very much needed.

I took the liberty of pulling the changes out into a AsyncDatabaseSessionService in this gist so it can be used. I think it should "just work". The tests pass using it anyway.

Cheers!

Labels

services

7 participants

@GitMarco27 @iborko @matthiasak @fabiofumarola @mikeedjones @boyangsvl @adk-bot

feat: full async implementation of DatabaseSessionService #2889

Are you sure you want to change the base?

feat: full async implementation of DatabaseSessionService #2889

Uh oh!

Conversation

@GitMarco27 GitMarco27 commented Sep 9, 2025

Implement Full async DatabaseSessionService

Overview

Changes

Testing Plan

Unit Tests

Manual End-to-End Testing

Breaking Changes

Uh oh!

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

GitMarco27 commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iborko commented Sep 30, 2025

Uh oh!

matthiasak commented Oct 9, 2025

Uh oh!

fabiofumarola commented Oct 9, 2025

Uh oh!

mikeedjones commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GitMarco27 commented Sep 9, 2025 •

edited

Loading

mikeedjones commented Oct 14, 2025 •

edited

Loading