-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: passthrough extra args for adk deploy cloud_run as Cloud Run args
#2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Response from ADK Triaging Agent
Hello @jackwotherspoon, thank you for creating this PR!
To help us review this PR, could you please address the following from our contribution guidelines:
- Single Commit: Please squash the multiple commits into a single commit.
- Testing Plan: Please include a
testing plansection in your PR description to detail how you've tested these changes.
You can find more details in our contribution guidelines.
This information will help reviewers to review your PR more efficiently. Thanks!
Please add testing plan(log or screenshot)
Response from ADK Triaging Agent
Hello @jackwotherspoon, thank you for updating the PR with a testing plan!
Before this can be reviewed, could you please address the following:
- CI Checks: The
pyink-checkandtest (3.9)checks are failing. Please fix these issues so all checks are passing. - Single Commit: As mentioned previously, please squash the multiple commits into a single one.
You can find more details in our contribution guidelines.
These changes are needed before the reviewers can proceed. Thank you!
@jackwotherspoon I see there is a merge conflict, could you help resolve?
...args Merge #2544 The command `adk deploy cloud_run` supports limited `gcloud run deploy` args 😢. Which makes the command fine for simple deployments... It should support all current and future Cloud Run deployment args for the command to be widely adopted. This can easily be done by passing through all extra args passed to `adk deploy cloud_run` to gcloud... This PR assumes any extra args/flags passed after `AGENT_PATH` are gcloud flags. ## Example ```sh # ADK flags adk deploy cloud_run \ --project=$GOOGLE_CLOUD_PROJECT \ --region=$GOOGLE_CLOUD_LOCATION \ $AGENT_PATH \ # Use the -- separator for gcloud args -- \ --min-instances=2 \ --no-allow-unauthenticated ``` This gives full Cloud Run feature support to ADK users 🤖 🚀 ## Test Plan To test you can just build locally or pip install feature branch directly: ``` uv venv uv pip install git+https://github.com/jackwotherspoon/adk-python.git ``` Deploy to Cloud Run using additional arguments following `AGENT_PATH`, such as `--min-instance=2` or `--description="Cloud Run test"`: ```sh uv run adk deploy cloud_run \ --project=$GOOGLE_CLOUD_PROJECT \ --region=$GOOGLE_CLOUD_LOCATION \ --with_ui \ $AGENT_PATH \ -- \ --labels=test-label=adk \ --min-instances=2 ``` You can click on the Cloud Run service after deployment and check the service yaml, you should see the additional label etc. <img width="1612" height="622" alt="image" src="https://github.com/user-attachments/assets/596a260a-0052-460b-9642-c18900ccf7c9" /> Fixes #2351 COPYBARA_INTEGRATE_REVIEW=#2544 from jackwotherspoon:main 184a4d7 PiperOrigin-RevId: 799252544
Uh oh!
There was an error while loading. Please reload this page.
The command
adk deploy cloud_runsupports limitedgcloud run deployargs 😢.Which makes the command fine for simple deployments...
It should support all current and future Cloud Run deployment args for the command to be widely adopted.
This can easily be done by passing through all extra args passed to
adk deploy cloud_runto gcloud...This PR assumes any extra args/flags passed after
AGENT_PATHare gcloud flags.Example
This gives full Cloud Run feature support to ADK users 🤖 🚀
Test Plan
To test you can just build locally or pip install feature branch directly:
Deploy to Cloud Run using additional arguments following
AGENT_PATH, such as--min-instance=2or--description="Cloud Run test":You can click on the Cloud Run service after deployment and check the service yaml, you should see the additional label etc.
imageFixes #2351