Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: Fix spelling #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsoref wants to merge 110 commits into google:main
base: main
Choose a base branch
Loading
from jsoref:spelling
Open

chore: Fix spelling #2447

jsoref wants to merge 110 commits into google:main from jsoref:spelling

Conversation

@jsoref
Copy link

@jsoref jsoref commented Aug 8, 2025

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/adk-python/actions/runs/16840838898/attempts/1#summary-47711379253

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/adk-python/actions/runs/16840839269/attempts/1#summary-47711380479

Note: while I use tooling to identify errors, the tooling doesn't actually provide the corrections, I'm picking them on my own. I'm a human, and I may make mistakes.

I've included a couple of changes to make CI happy. Personally, I object to CI being in a state of "random drive by person who adds a blank line in the middle of a file must fix all the preexisting bugs in the file", but that appears to be the state for this repository.

Copy link
Collaborator

adk-bot commented Aug 8, 2025

Response from ADK Triaging Agent

Hello @jsoref, thank you for creating this PR!

Could you please squash your commits into a single commit? Our contribution guidelines require that each PR has only one commit.

You can find more details in our contribution guidelines. Thanks!
jsoref reacted with thumbs down emoji

run: |
git fetch origin ${{ github.base_ref }}
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|tests/.*|contributing/samples/' || true)
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|src/google/adk/tools/apihub_tool/apihub_toolset.py|tests/.*|contributing/samples/' || true)
Copy link
Author

@jsoref jsoref Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI gets really mad without this, but it isn't my job to refactor this repository to make CI happy.

logger.debug("Module %s itself not found.", agent_name)
else:
# it's the case the module imported by {agent_name}.agent module is not
# the module imported by {agent_name}.agent module is not
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes I've rewrapped things, I didn't in this case.

# limitations under the License.

"""Utility functions for code execution."""
from __future__ import annotations
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this in a couple of places to make CI happy, but it really should be done for all files that care in the repo instead of forcing people to deal w/ it.

apihub_resource_name: The resource name of the API in API Hub.
Example: ``projects/test-project/locations/us-central1/apis/test-api``.
access_token: Google Access token. Generate with gcloud cli
``gcloud auth auth print-access-token``. Used for fetching API Specs from API Hub.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command was wrong...which is rather ironic...

"id": null,
"args": {
"agent_name": "indentify_agent"
"agent_name": "identify_agent"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd

@jsoref jsoref force-pushed the spelling branch 3 times, most recently from 8cf7016 to a4e06b4 Compare August 8, 2025 22:08
@jsoref jsoref changed the title (削除) Spelling (削除ここまで) (追記) chore: Fix spelling (追記ここまで) Aug 8, 2025
@adk-bot adk-bot added bot triaged documentation [Component] This issue is related to documentation, it will be transferred to adk-docs labels Aug 8, 2025
Copy link
Author

jsoref commented Aug 8, 2025

Dear robot, your instructions are broken, they say:

- Each PR should only have one commit. Please squash it if there are multiple PRs.
  • Each PR should only have one commit. Please squash it if there are multiple PRs.

I do not have multiple PRs, I have one. If you want to enforce things that aren't alphabet soup, please make demands that aren't nonsensical.

@jsoref jsoref force-pushed the spelling branch 2 times, most recently from 45b2603 to c53c261 Compare August 8, 2025 22:16
Copy link
Author

jsoref commented Aug 8, 2025

jsoref added 16 commits August 26, 2025 19:18 
Required by: Check for import pattern in certain changed Python files
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 26 commits August 26, 2025 19:22 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Copy link
Author

jsoref commented Aug 26, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polong-lin polong-lin Awaiting requested review from polong-lin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /