Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Report packages loading failure with a specific exit-code #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
podtserkovskiy wants to merge 1 commit into golangci:master
base: master
Choose a base branch
Loading
from podtserkovskiy:report_packages_loading_failure

Conversation

@podtserkovskiy
Copy link

@podtserkovskiy podtserkovskiy commented Aug 28, 2024

The packages.Load() function can use an external package provider GOPACKAGESDRIVER for third-party build-systems like Bazel or Buck2.

Having a specific exit code when external driver fails would increase observability and will help to distinguish GOPACKAGESDRIVER's failures from other kinds of failures.

Copy link

boring-cyborg bot commented Aug 28, 2024

Hey, thank you for opening your first Pull Request !

Copy link

CLAassistant commented Aug 28, 2024
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ldez ldez self-requested a review August 28, 2024 11:30
@ldez ldez added area: CLI Related to CLI blocked Need's direct action from maintainer labels Aug 28, 2024
Copy link
Author

@ldez Is there something I can do to get this PR merged?

ldez reacted with eyes emoji

Copy link
Member

ldez commented Jan 30, 2025

I'm unsure to understand how this "increases observability and will help to distinguish GOPACKAGESDRIVER's failures from other kinds of failures".
The error message is already "unique" 🤔

Can you provide more details?

@ldez ldez added waiting for: contributor feedback Requires additional feedback and removed blocked Need's direct action from maintainer labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldez ldez Awaiting requested review from ldez

Assignees

No one assigned

Labels

area: CLI Related to CLI waiting for: contributor feedback Requires additional feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /