-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls/internal/mcp: add go_rename tool #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: c9a4e51) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/694036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This tool uses the LSP server's Rename method to rename Go symbols (variables, functions, types, etc.) at a specified position. It supports both preview mode (dryRun: true, default) and actual application (dryRun: false) of changes across the workspace. - Add renameTool() and renameHandler() to the MCP server - Support dryRun parameter: true for preview, false to apply changes - Add TestMCPRename to test the tool for both dryRun modes - Update MCP instructions with go_rename usage examples for both modes Fixes golang/go#74887
c9a4e51 to
3f86730
Compare
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694036.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 3f86730) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/694036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Arjun Mahishi:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694036.
After addressing review feedback, remember to publish your drafts!
Message from Robert Findley:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694036.
After addressing review feedback, remember to publish your drafts!
Message from Arjun Mahishi:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694036.
After addressing review feedback, remember to publish your drafts!
Uh oh!
There was an error while loading. Please reload this page.
This tool uses the LSP server's Rename method to rename Go symbols
(variables, functions, types, etc.) at a specified position. It supports
both preview mode (dryRun: true, default) and actual application
(dryRun: false) of changes across the workspace.
Fixes golang/go#74887