-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci: update Go and staticcheck versions #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dominikh/staticcheck-action@v1.3.0 | ||
| with: | ||
| version: "2023年1月6日" | ||
| - uses: dominikh/staticcheck-action@v1.3.1 | ||
|
|
||
| list: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -31,10 +29,10 @@ jobs: | |
| import os | ||
| go = [ | ||
| # Keep the most recent production release at the top | ||
| '1.22', | ||
| '1.23', | ||
| # Older production releases | ||
| '1.22', | ||
|
Comment on lines
+32
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification The codebase currently specifies Go 1.20 in go.mod, which is significantly behind the proposed Go 1.23. While there are no Go 1.23-specific features used, upgrading the Go version requires:
Please update go.mod and verify the changes before merging. 🔗 Analysis chainLGTM! Verify Go 1.23 compatibility. The Go version updates look good:
Let's verify compatibility with Go 1.23. Let me gather more information about the build constraints and Go version requirements. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash # Description: Check for any Go 1.23-specific syntax or features in the codebase # that might cause compatibility issues # Test 1: Look for any Go 1.23 specific features or syntax echo "Checking for Go 1.23 specific features..." rg -l 'go1\.23' # Test 2: Check go.mod for compatibility echo "Checking go.mod for version constraints..." if [ -f "go.mod" ]; then cat go.mod | grep -A 5 "^go " fi # Test 3: Look for any build constraints echo "Checking for build constraints..." rg -l '//\s*\+build\s+' rg -l '//go:build' Length of output: 561 Script: #!/bin/bash # Check the specific build constraints and their version requirements echo "Checking build constraint contents..." rg "//go:build|//\s*\+build" -A 2 # Check for any version-specific code or dependencies echo "Checking go.mod dependencies..." cat go.mod # Look for any potential compatibility issues in the code echo "Checking for version-sensitive features..." rg "(?i)go1\.[0-9]{2}" --type go Length of output: 1501 |
||
| '1.21', | ||
| '1.20', | ||
| ] | ||
| mysql = [ | ||
| '9.0', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module github.com/go-sql-driver/mysql | ||
|
|
||
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| require filippo.io/edwards25519 v1.1.0 |