Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support opening branches popup from all tabs #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kpbaks wants to merge 1 commit into gitui-org:master
base: master
Choose a base branch
Loading
from kpbaks:open-branches-from-all-tabs

Conversation

@kpbaks
Copy link

@kpbaks kpbaks commented Aug 31, 2025
edited
Loading

This Pull Request makes it so pressing b opens the Branches popup in all 5 tabs, not only Status and Log tab. This keeps the behavior consistent, and makes the program simpler to use, since you do not have to associate being in a subset of the available tabs, in order to open a, what I would consider, global popup.

The b is not being used in any of the 3 missing tabs, so the change does not conflict with any existing keybinds.

If accepted, I think it would benefit the codebase to have a concept of global keybinds, that are accessible from all tabs, to deduplicate the repeated code to e.g. add a branches keybind.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@kpbaks kpbaks force-pushed the open-branches-from-all-tabs branch from 1153424 to 9407b4e Compare August 31, 2025 14:50
@kpbaks kpbaks changed the title (削除) Open branches popup from all tabs (削除ここまで) (追記) Support opening branches popup from all tabs (追記ここまで) Aug 31, 2025
Copy link
Collaborator

@kpbaks great idea! Why is it draft?

Copy link
Author

kpbaks commented Sep 17, 2025

Miss-click I think 😅

@kpbaks kpbaks force-pushed the open-branches-from-all-tabs branch from 9407b4e to 928e421 Compare September 17, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /