-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Implement name validation before server calls on Org creation #18815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see a case where the name was empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fast enough and not worth maintaining validation logic twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Siddhant-K-code for caring about the UX!
We want to avoid maintaining validation logic and error messages twice, unless there is a good reason. In this case, the UI feedback seems absolutely fine as it is. So I'd rather not add code unnecessarily. Let me know if I have missed something. 🙏
Absolutely, I'll proceed to close the PR. The main goal was to initiate communication with the server only after conducting fundamental validation on the frontend. However, I understand your concern regarding the management of duplicates. The primary reference for this was:
gitpod/components/dashboard/src/projects/ProjectSettings.tsx
Lines 51 to 55 in 1b68720
Thanks! We should definitely be more consistent and rely on server-side validation as much as reasonable.
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR addresses the need for adding a basic organization name validation before making server calls during the organization creation process.
Impact
The goal is to optimize server load and elevate user experience by confirming that only valid organization names are processed. Currently, calls are made to the createTeam endpoint even when the name is empty. This approach allows users to promptly receive basic error messages for issues like empty fields and character limits, instead of sending a request to the server and then displaying the error on the UI, a process that typically takes approximately 1.2 seconds for updates.
Summary generated by Copilot
🤖 Generated by Copilot at b21dc8e
Added placeholders and validation for team and project names. This enhances the usability and feedback of the dashboard UI.
Related Issue(s)
Fixes #
How to test
Create organizationwhen input box is empty & see error message 👀Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold