Adding default toolset as configuration #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tonytrg merged 14 commits into main from tonytrg/add-default

Oct 15, 2025

Merged

Adding default toolset as configuration #1229

tonytrg merged 14 commits into main from tonytrg/add-default

Oct 15, 2025

+390 −23

Conversation

@tonytrg

Copy link

Contributor

@tonytrg tonytrg commented Oct 15, 2025 •

edited

Loading

Context

As we now introduce default toolsets, we want to enable the workflow to quickly add specific toolsets to the current experience.

Right now this requires copying and recreating the default toolset and adding the specific toolsets.
To make it easier to configure we allow the additional special toolset default.

Changes

introduced default toolset
we clean up the provided toolset list from the passed args/envs to make the tool selection logic cleaner and more predictable
introduces tests
adds warning that invalid toolsets were passed

2025年10月15日 17:52:32.186 [warning] [server stderr] Invalid toolsets ignored: actionss, test

updates the cli help message

go run cmd/github-mcp-server/main.go --help
A GitHub MCP server that handles various tools and resources.
Usage:
 server [command]
Available Commands:
 completion Generate the autocompletion script for the specified shell
 help Help about any command
 stdio Start stdio server
Flags:
 --content-window-size int Specify the content window size (default 5000)
 --dynamic-toolsets Enable dynamic toolsets
 --enable-command-logging When enabled, the server will log all command requests and responses to the log file
 --export-translations Save translations to a JSON file
 --gh-host string Specify the GitHub hostname (for GitHub Enterprise etc.)
 -h, --help help for server
 --log-file string Path to log file
 --read-only Restrict the server to read-only operations
 --toolsets strings Comma-separated list of tool groups to enable (no spaces).
 Available: context, repos, issues, pull_requests, users, orgs, actions,
 code_security, secret_protection, dependabot, notifications,
 experiments, discussions, gists, security_advisories, projects,
 stargazers, dynamic, labels
 Special toolset keywords:
 - all: Enables all available toolsets
 - default: Enables the default toolset configuration of:
 context, repos, issues, pull_requests, users
 Examples:
 - --toolsets=actions,gists,notifications
 - Default + additional: --toolsets=default,actions,gists
 - All tools: --toolsets=all
 -v, --version version for server
Use "server [command] --help" for more information about a command.

Closes:

tonytrg added 2 commits

October 15, 2025 15:36

@tonytrg


 add toolset default to make configuration easier

bb4e2d9

@tonytrg


 fix readme

7cdf26f

khondakar1

This comment was marked as spam.

tonytrg added 6 commits

October 15, 2025 15:56

@tonytrg


 adding transformer to cleanly handle special toolsets

8d2995d

@tonytrg


 Merge branch 'main' into tonytrg/add-default

@tonytrg


 cleaning code

69b1a3a

@tonytrg


 Merge branch 'tonytrg/add-default' of github.com:github/github-mcp-se...

b37be61

...rver into tonytrg/add-default

@tonytrg


 fixing cli message

0c8980d

@tonytrg


 remove duplicated test

5dfeaca

@tonytrg tonytrg changed the title ~~(削除) Tonytrg/add default (削除ここまで)~~ (追記) Adding default toolset as configuration (追記ここまで)

Oct 15, 2025

@tonytrg tonytrg marked this pull request as ready for review

October 15, 2025 15:07

@tonytrg tonytrg requested a review from a team as a code owner

October 15, 2025 15:07

Copilot AI review requested due to automatic review settings

October 15, 2025 15:07

Copilot AI reviewed

Oct 15, 2025

View reviewed changes

Copy link

Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a special "default" toolset configuration to simplify workflow setup when working with default and additional toolsets. Instead of requiring users to copy and recreate the default toolset and add specific toolsets, they can now use the default keyword to quickly reference the standard configuration.

Adds a special default toolset keyword that expands to the standard toolset configuration
Implements cleanToolsets function to handle toolset processing logic including deduplication and special keyword expansion
Updates CLI help documentation to explain the new special toolset keywords and provide usage examples

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/github/tools.go	Adds metadata for special toolsets and updates help text generation
internal/ghmcp/server.go	Implements cleanToolsets function and integrates it into server initialization
internal/ghmcp/server_test.go	Comprehensive test suite for the cleanToolsets function
cmd/github-mcp-server/main.go	Updates default toolset initialization to use the new default keyword
README.md	Updates documentation to explain special toolsets and usage patterns

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

internal/ghmcp/server.go Show resolved Hide resolved

internal/ghmcp/server_test.go Outdated Show resolved Hide resolved

tonytrg and others added 2 commits

October 15, 2025 17:08

@tonytrg


 Update internal/ghmcp/server.go

6c9c201

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@tonytrg


 Update internal/ghmcp/server_test.go

d786306

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

omgitsads

omgitsads previously approved these changes

Oct 15, 2025

View reviewed changes

tonytrg added 2 commits

October 15, 2025 17:43

@tonytrg


 adding error message for invalid toolsets

@tonytrg


 adding error message

809a8fc

@tonytrg tonytrg dismissed omgitsads’s stale review via

809a8fc

October 15, 2025 15:43

tonytrg added 2 commits

October 15, 2025 17:46

@tonytrg


 fix merge conflict

40fbb6c

@tonytrg


 add better formatting

f42f866

omgitsads

omgitsads approved these changes

Oct 15, 2025

View reviewed changes

@khondakar1

Copy link

khondakar1 commented Oct 15, 2025

Stop all approval request

@khondakar1

Copy link

khondakar1 commented Oct 15, 2025

Stop all approval request

@khondakar1 khondakar1 mentioned this pull request

Oct 15, 2025

> Stop all approval request #1233

Closed

@tonytrg tonytrg merged commit 66fabb7 into main

Oct 15, 2025

16 checks passed

@tonytrg tonytrg deleted the tonytrg/add-default branch

October 15, 2025 16:20

@tonytrg tonytrg mentioned this pull request

Oct 16, 2025

Add a default toolset option #1228

Closed

@LadyKerr LadyKerr mentioned this pull request

Oct 16, 2025

Release Notes: v1.1.1 – Features, Bug Fixes, Documentation, and Maintenance LadyKerr/github-mcp-server#2

Open

pohi99999 added a commit to pohi99999/github-mcp-server that referenced this pull request

Oct 19, 2025

@pohi99999


 Merge branch 'main' of https://github.com/github/github-mcp-server

0e23aaf

* 'main' of https://github.com/github/github-mcp-server:
 Add Gemini CLI extension (github#1232)
 Adding default toolset as configuration (github#1229)

@BrewTestBot BrewTestBot mentioned this pull request

Oct 20, 2025

github-mcp-server 0.19.0 Homebrew/homebrew-core#250360

Merged

@github-actions github-actions bot mentioned this pull request

Oct 20, 2025

[ca] Update GitHub MCP Server to v0.19.0 githubnext/gh-aw#2034

Closed

Copilot AI mentioned this pull request

Oct 20, 2025

Update GitHub MCP Server to v0.19.0 and add "default" toolset support githubnext/gh-aw#2035

Merged

Labels

None yet

4 participants

@tonytrg @khondakar1 @omgitsads

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Adding default toolset as configuration #1229

Adding default toolset as configuration #1229

Conversation

@tonytrg tonytrg commented Oct 15, 2025 •

edited

Loading

Uh oh!

Context

Changes

Uh oh!

This comment was marked as spam.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

khondakar1 commented Oct 15, 2025

Uh oh!

khondakar1 commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Adding default toolset as configuration #1229

Adding default toolset as configuration #1229

Conversation

@tonytrg tonytrg commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Changes

Uh oh!

This comment was marked as spam.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

khondakar1 commented Oct 15, 2025

Uh oh!

khondakar1 commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

@tonytrg tonytrg commented Oct 15, 2025 •

edited

Loading