Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(core): Remove default value of maxValueLength: 250 #18043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s1gr1d wants to merge 1 commit into develop
base: develop
Choose a base branch
Loading
from sig/sdk-maxValueLength

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 28, 2025

The SDK should only truncate when really necessary on the client. Therefore, the default value of 250 is removed.

Part of #17389

sentry-io[bot] reacted with hooray emoji
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.62 kB -0.02% -3 B 🔽
@sentry/browser - with treeshaking flags 23.11 kB -0.02% -3 B 🔽
@sentry/browser (incl. Tracing) 40.97 kB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Profiling) 45.26 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay) 79.29 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.97 kB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 83.99 kB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 96.15 kB -0.01% -3 B 🔽
@sentry/browser (incl. Feedback) 41.3 kB -0.01% -3 B 🔽
@sentry/browser (incl. sendFeedback) 29.29 kB -0.01% -2 B 🔽
@sentry/browser (incl. FeedbackAsync) 34.22 kB -0.01% -3 B 🔽
@sentry/react 26.31 kB -0.01% -2 B 🔽
@sentry/react (incl. Tracing) 42.97 kB - -
@sentry/vue 29.11 kB -0.02% -3 B 🔽
@sentry/vue (incl. Tracing) 42.75 kB -0.01% -3 B 🔽
@sentry/svelte 24.63 kB -0.02% -3 B 🔽
CDN Bundle 26.9 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing) 41.62 kB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Replay) 77.87 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB - -
CDN Bundle - uncompressed 78.86 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 123.45 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.49 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.25 kB +0.01% +4 B 🔺
@sentry/nextjs (client) 45.11 kB -0.01% -1 B 🔽
@sentry/sveltekit (client) 41.4 kB -0.01% -1 B 🔽
@sentry/node-core 50.75 kB - -
@sentry/node 157.81 kB -0.01% -1 B 🔽
@sentry/node - without tracing 92.63 kB - -
@sentry/aws-serverless 106.35 kB - -

View base workflow run

Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,255 - 8,558 +8%
GET With Sentry 1,334 14% 1,326 +1%
GET With Sentry (error only) 6,054 65% 5,986 +1%
POST Baseline 1,192 - 1,184 +1%
POST With Sentry 544 46% 536 +1%
POST With Sentry (error only) 1,049 88% 1,040 +1%
MYSQL Baseline 3,222 - 3,240 -1%
MYSQL With Sentry 453 14% 394 +15%
MYSQL With Sentry (error only) 2,694 84% 2,637 +2%

View base workflow run

@s1gr1d s1gr1d requested review from JPeer264 and Lms24 October 28, 2025 14:13
Copy link
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I am just not sure if this isn't considered a breaking change. Since it would behave now differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /