feat(replay): ignore `background-image` when `blockAllMedia` is enabled #18019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

billyvg wants to merge 2 commits into develop

from billy/feat-replay-ignore-background-css-inline

Open

feat(replay): ignore `background-image` when `blockAllMedia` is enabled #18019

billyvg wants to merge 2 commits into develop from billy/feat-replay-ignore-background-css-inline

+34 −24

Conversation

@billyvg

Copy link

Member

@billyvg billyvg commented Oct 23, 2025

Pass ignoreCSSAttributes with background-imgae to ignore background images when blockAllMedia is enabled. ignoreCSSAttributes was expanded in this PR so that it also works for inline styles.

@github-actions

Copy link

Contributor

github-actions bot commented Oct 23, 2025 •

edited

Loading

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	24.63 kB	-	-
@sentry/browser - with treeshaking flags	23.11 kB	-	-
@sentry/browser (incl. Tracing)	40.97 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	45.26 kB	-	-
@sentry/browser (incl. Tracing, Replay)	79.52 kB	+0.29%	+228 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	69.2 kB	+0.33%	+226 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	84.22 kB	+0.28%	+227 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	96.38 kB	+0.24%	+225 B 🔺
@sentry/browser (incl. Feedback)	41.3 kB	-	-
@sentry/browser (incl. sendFeedback)	29.29 kB	-	-
@sentry/browser (incl. FeedbackAsync)	34.22 kB	-	-
@sentry/react	26.31 kB	-	-
@sentry/react (incl. Tracing)	42.97 kB	-	-
@sentry/vue	29.11 kB	-	-
@sentry/vue (incl. Tracing)	42.75 kB	-	-
@sentry/svelte	24.64 kB	-	-
CDN Bundle	26.9 kB	-	-
CDN Bundle (incl. Tracing)	41.62 kB	-	-
CDN Bundle (incl. Tracing, Replay)	78.12 kB	+0.32%	+247 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	83.58 kB	+0.28%	+233 B 🔺
CDN Bundle - uncompressed	78.86 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	123.44 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	239.33 kB	+0.36%	+846 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	252.09 kB	+0.34%	+846 B 🔺
@sentry/nextjs (client)	45.11 kB	-	-
@sentry/sveltekit (client)	41.4 kB	-	-
@sentry/node-core	50.75 kB	-0.01%	-1 B 🔽
@sentry/node	157.81 kB	+0.01%	+1 B 🔺
@sentry/node - without tracing	92.63 kB	+0.01%	+1 B 🔺
@sentry/aws-serverless	106.35 kB	-	-

View base workflow run

@github-actions

Copy link

Contributor

github-actions bot commented Oct 23, 2025 •

edited

Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	11,417	-	9,643	+18%
GET With Sentry	1,616	14%	1,422	+14%
GET With Sentry (error only)	7,808	68%	6,216	+26%
POST Baseline	1,183	-	1,219	-3%
POST With Sentry	528	45%	561	-6%
POST With Sentry (error only)	1,062	90%	1,071	-1%
MYSQL Baseline	4,130	-	3,392	+22%
MYSQL With Sentry	543	13%	477	+14%
MYSQL With Sentry (error only)	3,375	82%	2,748	+23%

View base workflow run

@billyvg billyvg marked this pull request as ready for review

October 23, 2025 17:50

@billyvg billyvg requested a review from a team as a code owner

October 23, 2025 17:50

@billyvg billyvg requested a review from chargome

October 23, 2025 17:51

billyvg added 2 commits

October 24, 2025 13:28

@billyvg


 feat(replay): ignore background-image when blockAllMedia is enabled

0ec4190

Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.

@billyvg