Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore(browser): upgrade fake-indexeddb to v6 #17975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 1 commit into develop from abhi-upgrade-fake-indexeddb-v6
Oct 28, 2025

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Oct 20, 2025

changelog: https://github.com/dumbmatter/fakeIndexedDB/blob/master/CHANGELOG.md

removes a structured clone polyfill, which is fine because we are node 18+ in the SDK. This helps reduce dep count in yarn.lock.

seer-by-sentry[bot] reacted with hooray emoji
@AbhiPrasad AbhiPrasad requested a review from a team October 20, 2025 15:08
@AbhiPrasad AbhiPrasad self-assigned this Oct 20, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and andreiborza and removed request for a team October 20, 2025 15:08
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,775 - 9,643 -9%
GET With Sentry 1,377 16% 1,422 -3%
GET With Sentry (error only) 6,079 69% 6,216 -2%
POST Baseline 1,191 - 1,219 -2%
POST With Sentry 528 44% 561 -6%
POST With Sentry (error only) 1,061 89% 1,071 -1%
MYSQL Baseline 3,285 - 3,392 -3%
MYSQL With Sentry 444 14% 477 -7%
MYSQL With Sentry (error only) 2,676 81% 2,748 -3%

View base workflow run

@AbhiPrasad AbhiPrasad force-pushed the abhi-upgrade-fake-indexeddb-v6 branch 2 times, most recently from 683e5f3 to b4a6ade Compare October 22, 2025 13:22
@AbhiPrasad AbhiPrasad force-pushed the abhi-upgrade-fake-indexeddb-v6 branch from b4a6ade to 756aba5 Compare October 24, 2025 15:03
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't checked changes between v4 and v6. Is there anything in there that could break us?

Copy link
Member Author

Nothing from what I saw, but we can revert if we see something suspicious.

@AbhiPrasad AbhiPrasad merged commit 0e15b3d into develop Oct 28, 2025
57 of 58 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-fake-indexeddb-v6 branch October 28, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreiborza andreiborza andreiborza approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-javascript-sdks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /