Commit e05acdd

authored

fix(node): Pino capture serialized err (#17999)

1 parent 7aa886c commit e05acddCopy full SHA for e05acdd

File tree

2 files changed

-2

lines changed

dev-packages/node-integration-tests/suites/pino
- test.ts
packages/node-core/src/integrations
- pino.ts

2 files changed

-2

lines changed

`‎dev-packages/node-integration-tests/suites/pino/test.ts‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ conditionalTest({ min: 20 })('Pino integration', () => {`
`84`	`84`	`attributes: {`
`85`	`85`	`name: { value: 'myapp', type: 'string' },`
`86`	`86`	`module: { value: 'authentication', type: 'string' },`
	`87`	`+ msg: { value: 'oh no', type: 'string' },`
	`88`	`+ err: { value: expect.any(String), type: 'string' },`
`87`	`89`	`'pino.logger.level': { value: 50, type: 'integer' },`
`88`	`90`	`'sentry.origin': { value: 'auto.logging.pino', type: 'string' },`
`89`	`91`	`'sentry.release': { value: '1.0', type: 'string' },`
`@@ -159,6 +161,8 @@ conditionalTest({ min: 20 })('Pino integration', () => {`
`159`	`161`	`severity_number: 17,`
`160`	`162`	`attributes: {`
`161`	`163`	`name: { value: 'myapp', type: 'string' },`
	`164`	`+ msg: { value: 'oh no', type: 'string' },`
	`165`	`+ err: { value: expect.any(String), type: 'string' },`
`162`	`166`	`'pino.logger.level': { value: 50, type: 'integer' },`
`163`	`167`	`'sentry.origin': { value: 'auto.logging.pino', type: 'string' },`
`164`	`168`	`'sentry.release': { value: '1.0', type: 'string' },`
`@@ -211,6 +215,7 @@ conditionalTest({ min: 20 })('Pino integration', () => {`
`211`	`215`	`name: { value: 'myapp', type: 'string' },`
`212`	`216`	`module: { value: 'authentication', type: 'string' },`
`213`	`217`	`msg: { value: 'oh no', type: 'string' },`
	`218`	`+ err: { value: expect.any(String), type: 'string' },`
`214`	`219`	`'pino.logger.level': { value: 50, type: 'integer' },`
`215`	`220`	`'sentry.origin': { value: 'auto.logging.pino', type: 'string' },`
`216`	`221`	`'sentry.release': { value: '1.0', type: 'string' },`

`‎packages/node-core/src/integrations/pino.ts‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,12 +86,11 @@ type PinoResult = {`
`86`	`86`	`time?: string;`
`87`	`87`	`pid?: number;`
`88`	`88`	`hostname?: string;`
`89`		`- err?: Error;`
`90`	`89`	`} & Record<string, unknown>;`
`91`	`90`
`92`	`91`	`function stripIgnoredFields(result: PinoResult): PinoResult {`
`93`	`92`	`// eslint-disable-next-line @typescript-eslint/no-unused-vars`
`94`		`- const { level, time, pid, hostname, err,...rest } = result;`
	`93`	`+ const { level, time, pid, hostname, ...rest } = result;`
`95`	`94`	`return rest;`
`96`	`95`	`}`
`97`	`96`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit e05acdd

File tree

2 files changed

2 files changed

`‎dev-packages/node-integration-tests/suites/pino/test.ts‎`

`‎packages/node-core/src/integrations/pino.ts‎`

0 commit comments