Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 7aa886c

Browse files
test(hono): Fix hono e2e tests (#18000)
ATM there are failing Hono E2E tests (e.g. [here](https://github.com/getsentry/sentry-javascript/actions/runs/18714106732/job/53370082672?pr=17998)), which print out following: ```sh Error: src/index.ts(20,3): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. ``` The reason was, that the types were not there yet. I just wonder why it was working before. In follow up PRs I will try to update Cloudflare tests with its integrations.
1 parent f895f09 commit 7aa886c

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

‎dev-packages/e2e-tests/test-applications/cloudflare-hono/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"devDependencies": {
1818
"@cloudflare/vitest-pool-workers": "^0.8.31",
1919
"@cloudflare/workers-types": "^4.20250521.0",
20+
"typescript": "^5.9.3",
2021
"vitest": "3.1.0",
2122
"wrangler": "4.22.0"
2223
},

‎dev-packages/e2e-tests/test-applications/cloudflare-hono/tsconfig.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
"skipLibCheck": true,
88
"lib": ["ESNext"],
99
"jsx": "react-jsx",
10+
"types": ["@cloudflare/workers-types/experimental"],
1011
"jsxImportSource": "hono/jsx"
1112
},
1213
"include": ["src/**/*"],

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /