Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix presence channel #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeboot merged 1 commit into georgeboot:master from nenads:master
Dec 28, 2021
Merged

fix presence channel #15

georgeboot merged 1 commit into georgeboot:master from nenads:master
Dec 28, 2021

Conversation

@nenads
Copy link
Contributor

@nenads nenads commented Dec 26, 2021
edited
Loading

Hi love what have you done so far.

There is issue with presence channel:

  1. Auth route returns extra data:
{"auth":"2edb16a0a48b7cb9","channel_data":"{\"user_id\":1,\"user_info\":{\"id\":1,\"name\":\"admin\"}}"}

Channel data needs to be send over Web-Socket to correspond with auth token for that channel.

  1. Backed was json encoding string so auth would fail, since request parameter was never converted to array in first place.

Copy link

codecov bot commented Dec 28, 2021
edited
Loading

Codecov Report

Merging #15 (72efe49) into master (957ce4f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #15 +/- ##
=========================================
 Coverage 43.31% 43.31% 
 Complexity 53 53 
=========================================
 Files 9 9 
 Lines 344 344 
 Branches 14 14 
=========================================
 Hits 149 149 
 Misses 187 187 
 Partials 8 8 
Flag Coverage Δ
jest 54.47% <ø> (ø)
pest-8.0 37.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js-src/Websocket.ts 61.42% <ø> (ø)
src/Handler.php 63.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 957ce4f...72efe49. Read the comment docs.

@georgeboot georgeboot merged commit 612cb4a into georgeboot:master Dec 28, 2021
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /