-
Notifications
You must be signed in to change notification settings - Fork 67
fix(heading): initially follow theme's margin if OceanWP is used #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Pull request artifacts
|
Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3349-stackable-3349-merge.zip"}}]}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue is with OceanWP only, it would be better to have a fix that would be applicable only with OceanWP and only targets the issue. Adjusting all blocks for all scenarios would pose more issues. Also, we have default margins for our blocks, this removes them
fixes #3259