Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do selective lodash cloneDeep import #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddieux wants to merge 1 commit into fusioncharts:master
base: master
Choose a base branch
Loading
from leadiq:selective-lodash-import

Conversation

@eddieux
Copy link

@eddieux eddieux commented Jun 1, 2020

It looks like that dist/vue-fusioncharts.js includes the whole lodash library, which makes it very huge (over 20k lines)

Proposing to do a selective import instead, since only cloneDeep function is used.

thiloplanz, devatleadiq, and mccxiv reacted with thumbs up emoji
pranavp94 pushed a commit that referenced this pull request Oct 12, 2020
...butor Pull Requests]
Contributer PR #65 changes, do selective lodash cloneDeep import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /