Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

After installing aoc-cli cargo download not working #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peteanning wants to merge 3 commits into fspoettel:main from peteanning:main

Conversation

@peteanning
Copy link
Contributor

@peteanning peteanning commented Nov 6, 2022 

cargo download 01 --year 2021
 Compiling pico-args v0.5.0
 Compiling aoc v0.6.2 (/Users/peter/projects/sandbox/tmp/advent-of-code-rust)
 Finished dev [unoptimized + debuginfo] target(s) in 1.59s
 Running `target/debug/download 01 --year 2021`
Downloading input via aoc-cli...
error: Found argument '--file' which wasn't expected, or isn't valid in this context

Reading the docs the options come before the command.

This change puts the command after the options and for me now works?

Copy link
Owner

fspoettel commented Nov 6, 2022 •
edited
Loading

(削除) Strange, this works for me on all OS I have access to (macOS 12, windows 10, ubuntu 20.04). What OS are you seeing this on? (削除ここまで)

(削除) Looking at the docs, your change looks good, so it definitely makes sense to merge either way. (削除ここまで)

Copy link
Owner

fspoettel commented Nov 6, 2022 •
edited
Loading

This broke between aoc-cli@0.3.0 and aoc-cli@0.4.0 released yesterday - their old arg parser did not enforce the documented argument order.

Copy link
Owner

@peteanning Thank you for reporting the regression with the new aoc-cli version and the prompt fix! 😊

As I wasn't able to push changes to this PR, I went ahead and merged your commit as 132fb66 via 7, leaving attribution intact.

Copy link
Contributor Author

peteanning commented Nov 6, 2022 via email

I am on Mac OS an Quad-Core Intel Core i7 MacBook Pro Running BigSur 11.6.8 aoc-cli 0.4.0 It may not have always been this way this old version of the README shows the alternate way you did it: https://github.com/scarvalhojr/aoc-cli/blame/9022d5dd0765587672dce80b49c37da42af51c6a/README.md#L139 What does `aoc -V` show on your environment?
...
On Sun, 6 Nov 2022 at 20:03, Felix Spöttel ***@***.***> wrote: Strange, this works for me on all OS I have access to (macOS, windows, ubuntu). What OS are you seeing this on? Looking at the docs, your change looks good, so it definitely makes sense to merge either way. — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJ5TQOVYMENQYETCNSSSMDWHAFKPANCNFSM6AAAAAARYONIZ4> . You are receiving this because you authored the thread.Message ID: ***@***.***>
-- { "name" : "*Peter Anning*", "mobile" : 07595948265, "twitter" : ***@***.***", "linkedIn" : "www.linkedin.com/in/peteranning" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fspoettel fspoettel fspoettel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /