Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a --no-readme flag to time command #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tguichaoua wants to merge 1 commit into fspoettel:main from tguichaoua:time-no-readme

Conversation

@tguichaoua
Copy link
Contributor

@tguichaoua tguichaoua commented Dec 11, 2023

Allow to not update readme table every time time is called.
Especially when using cargo time <day> multiple time in row.

Copy link
Owner

Maybe this is a good time to re-think how we approach the time command now that it is its own command.

The described behavior can be achieved by running cargo {solve|all} <day> --release --time, which is a lot of typing. Maybe istd. of introducing --no-readme, we can make --no-readme the default of time:

  1. Remove the --time flag from solve and all. Make this the default behavior of time.
  2. Add a --store flag to time to update the JSON & readme.

What do you think?

Copy link
Contributor Author

tguichaoua commented Dec 11, 2023
edited
Loading

Maybe this is a good time to re-think how we approach the time command now that it is its own command.

The described behavior can be achieved by running cargo {solve|all} <day> --release --time, which is a lot of typing. Maybe istd. of introducing --no-readme, we can make --no-readme the default of time:

  1. Remove the --time flag from solve and all. Make this the default behavior of time.
  2. Add a --store flag to time to update the JSON & readme.

What do you think?

I agree it will avoid having duplicate command behaviour 👍

Copy link
Owner

implemented in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /