-
Notifications
You must be signed in to change notification settings - Fork 61
feat: add incremental benchmarks #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tguichaoua
tguichaoua
suggested changes
Dec 10, 2023
@fspoettel
fspoettel
force-pushed
the
feat/incremental-timings
branch
3 times, most recently
from
December 10, 2023 12:21
cb0d0fb to
2ef57a8
Compare
Co-authored-by: Tristan Guichaoua <33934311+tguichaoua@users.noreply.github.com>
@fspoettel
fspoettel
force-pushed
the
feat/incremental-timings
branch
from
December 10, 2023 12:21
2ef57a8 to
0043528
Compare
thanks for the helpful review @tguichaoua, this should be ready now.
tguichaoua
tguichaoua
suggested changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last change 😉
The rest LGTM
Co-authored-by: Tristan Guichaoua <33934311+tguichaoua@users.noreply.github.com>
tguichaoua
tguichaoua
approved these changes
Dec 10, 2023
tguichaoua
added a commit
to tguichaoua/advent-of-code-2023-rust
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45