-
Notifications
You must be signed in to change notification settings - Fork 587
feat:Web_Socket_Support #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ashitaprasad I haven't finished on the history part of websocket (there is an error throwing because of this I would work on this once the approach is reviewed) . And still trying to make the scrolling functionality bit more smoother. Currently the new frames are pushing the old frames down , making it hard for tester to read when multiple frames comes fastly.
@ashitaprasad apart from above mentioned issues the branch is ready to review .
@Clasherzz hi, looked briefly at your PR and noticed that you have commited some generated files as well. The model files generated by the freezed package are meant to be gitignored. Maybe this can be of some help.
@Clasherzz hi, looked briefly at your PR and noticed that you have commited some generated files as well. The model files generated by the
freezedpackage are meant to be gitignored. Maybe this can be of some help.
I never thought to put them in git ignore since the codebase in github contains the generated files and already existing git ignore file in the codebase is not including them . And since the generated file code doesn't seem to vary across different dev enviornments I thought it wasn't going to cause conflict.
@Clasherzz
Some feedback :
- There shouldn’t be any errors across the project when you submit a PR
- GET, POST, GraphQL, cancel request etc. functionalities of the app are breaking
- When you write the websocket functionality you have to make sure it works along with the existing features of the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashitaprasad this was never supposed to be removed
@ashitaprasad kindly check this branch once again
PR Description
The PR discusses an approach for adding websocket support to API Dash.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
I haven't yet added test cases and would like to have some support for that
OS on which you have developed and tested the feature?