-
Notifications
You must be signed in to change notification settings - Fork 581
Added Proxy Configuration #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apart from the above comments, testing is also missing.
@ashitaprasad
I will make the required changes to make it cleaner, simpler, and optimized.
I have a question
- Should I create the ProxyModel in
packages\apidash_core\lib\models?
@ashitaprasad I will make the required changes to make it cleaner, simpler, and optimized.
I have a question
- Should I create the ProxyModel in
packages\apidash_core\lib\models?
Yes as it is being used by core service (sending http request)
@ashitaprasad
I have completed all the changes required.
I have also added tests for the feature.
Hi @ashitaprasad, is there any update regarding this PR.
@abhinavs1920 It is under review.
57e6947 to
23816ee
Compare
Please review the changes I have made to address the issues you mentioned.
I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.
Please review the changes I have made to address the issues you mentioned.
I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.
@ashitaprasad Any update?
Thanks!
@ashitaprasad
Please look at the implementation after the updates I did.
Let me know if the approach is fine.
I'll update the branch and resolve the conflicts.
PR Description
This pull request implements a feature that allows users to configure and use a proxy for their HTTP requests within the API Dash application. The feature includes a user interface for inputting proxy settings, storing these settings, and applying them to HTTP requests made using the http package in Flutter.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
image
I have tested the proxy feature by running a squid proxy server in Python. Above I have attached the image proving that the proxy is working perfectly fine.
OS on which you have developed and tested the feature?