-
Couldn't load subscription status.
- Fork 196
Handle npz files
#865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle npz files
#865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, this introduces a lot of needed features in stdlib. However, it is hard to review because it introduces three new features to stdlib, which are dependent but each should have their own independent review.
It would be great if you could open a PR for the filesystems first, a PR for the zip support second and finally a PR for the npz support.
Having dependent PRs is a bit challenging for reviewing. One option would be to push the three branches to the stdlib repo and open PRs from within the stdlib repo, as this improves the experience of reviewing dependent branches. Alternatively, you can open PRs from all three branches from your fork and we try to focus the review only on the parts introduced by the respective PR.
Please let me know if you need any support with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. Could you open a PR specific for the additions related to stdlib_array, please? It will make the review of this PR easier. Let me know if you need help.
Adds handling (loading and saving of
npzfiles).As an
npzfile is nothing butnpyfiles zipped together to a single file, we either need to include a library that handleszipfile creation/extraction for us or call system programs via the command line. In contrast to a previous attempt (#771), this PR uses the shell to extract and compress npz files.npzfiles.npz.Related Issues:
#486
#763