Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fixed bug in stringlist #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aman-godara wants to merge 7 commits into fortran-lang:master
base: master
Choose a base branch
Loading
from aman-godara:stringlist-bugfix

Conversation

@aman-godara
Copy link
Member

@aman-godara aman-godara commented Oct 10, 2021

If the inserted slist has length 0, then insert_at can give seg-fault error in this code:

do i = work_idxn + post_length - pre_length, post_length
 list%stringarray(inew) = slist%stringarray(i)
 inew = inew + 1
end do

Resolved by: adding an if-else statement to check for length of slist

jvdp1 reacted with thumbs up emoji

This comment has been minimized.

This comment has been minimized.

Copy link
Member Author

aman-godara commented Oct 15, 2021 •
edited
Loading

Any reason why test cases won't pass specifically for macos compiler. I rechecked everything many times but couldn't find any error in logic, I wanted to know if I am making some mistake by making some assumption which is invalid for macos's compiler.

PS: all test cases pass for my gfortran 10.2.0 windows, ran cmake --build build --target clean as well.

@aman-godara aman-godara force-pushed the stringlist-bugfix branch 5 times, most recently from 7c04491 to c5ea35d Compare October 17, 2021 11:36
Copy link
Member Author

aman-godara commented Oct 17, 2021 •
edited
Loading

As per my analysis:

call number 14 to function compare_list is failing because:

work_list <- ["-100", "-99", ..., "99", "100"] (201 items)

I am trying to insert work_list at the head of work_list, expecting an output: ["-100", "-99", ..., "99", "100", "-100", "-99", ..., "99", "100"] (402 items).

This is what I am getting as the output from macos compiler: ["", "", ..., "", "", "-100", "-99", ..., "99", "100"] (402 items)

Copy link
Member

jvdp1 commented Dec 22, 2021

What is the status of this PR? How can we help to move forward?

Copy link
Member Author

@jvdp1 Thanks for contacting. PR is stuck here, I tried many different things. I have mentioned the details of the problem here.

I am planning to make these test cases readable for others (I should have thought to do that earlier).
But I don't understand why all test cases passes on my GCC compiler but not here on GitHub. This is also preventing me from diving deep into the issue because I have to make a commit everytime and push it to GitHub to see if it works or not. That's why you will see those "temp commits" in the logs.

Copy link
Member

jvdp1 commented Dec 26, 2021

Strange...
I also tested this commit bb30a55a53b3728232727a3afdce168900b0be66 using Fedora with GCC 11.2.0, and all tests passed.
I'll try to look further in the next days...
aman-godara reacted with thumbs up emoji

Copy link
Member Author

Any luck? @jvdp1

Copy link
Member

jvdp1 commented Jan 11, 2022

Any luck? @jvdp1

No :( And then the holidays arrived. It is also difficult to run tests as I don't have a MacOS computer. Anyone with a MaCOS to test this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /