-
Couldn't load subscription status.
- Fork 196
Added code_coverage support. #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
master@eb46153). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1039 +/- ## ========================================= Coverage ? 25.12% ========================================= Files ? 570 Lines ? 234201 Branches ? 41275 ========================================= Hits ? 58846 Misses ? 175355 Partials ? 0
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @loiseaujc, however, I have no experience in codecoverage CI setups.
Co-authored-by: Federico Perini <federico.perini@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you @loiseaujc
Requires a CODECOV_TOKEN to be set up in the settings of the repo. This should be done by the one of the org owners I believe.
I'll poke @milancurcic and/or @certik, maybe they could help with this?
Thanks, @loiseaujc. I set the CODECOV_TOKEN as an Actions secret on this repo.
@loiseaujc @perazz if this PR is ready, it can be merged IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @loiseaujc. I tried to parametrize the key tools version but it didn't work as expected.
Uh oh!
There was an error while loading. Please reload this page.
Following the discussion in #937, this PR add code coverage to stdlib using codecov.
Key facts
fpm-deployment.ymlAction with code coverage.Ping: @perazz, @jalvesz, @jvdp1
PS : This is a re-opening of #1024 which was closed when I randomly decided to delete my fork.