Skip to content

fix: to_num_from_stream pointer position correction #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

jalvesz merged 1 commit into fortran-lang:master from jalvesz:to_num

Jun 9, 2025

Merged

fix: to_num_from_stream pointer position correction #1000

jalvesz merged 1 commit into fortran-lang:master from jalvesz:to_num

Jun 9, 2025

Conversation

Copy link

Contributor

@jalvesz jalvesz commented Jun 8, 2025

This PR fixes the computation of the position in a character stream for the to_num_from_stream function to properly advance when the character is a long chain. Otherwise, negative numbers can be obtained from len(s, lind=int8) if the string is in effect larger than 127.


 fix current position of pointer

ee41d92

jvdp1 reviewed

View reviewed changes

src/stdlib_str2num.fypp

!----------------------------------------------

call to_num_base(s,v,p,err)

p = min( p , len(s, kind = int8) )

p = min( p , len(s) )

Copy link

Member

@jvdp1 jvdp1 Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As p is declared as integer(int8), similar issues might still happen. Maybe also declare p as integer :: p? Or do you think it is not needed?

Copy link

Contributor Author

@jalvesz jalvesz Jun 8, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed as the kind is converted as an output of min. It could happen if an individual number is written on more than 127 characters. But even a quad number would fit.

jvdp1 approved these changes

View reviewed changes

Copy link

Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jalvesz . LGTM. See my suggestion below.

perazz approved these changes

View reviewed changes

@jalvesz jalvesz merged commit 25f94a9 into fortran-lang:master

16 checks passed

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

2b35517

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

fee2952

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

76ff34b

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

be1c08d

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

8cf3137

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

ccc6f87

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

a7c2264

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

ea4c56c

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

7b5c17e

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

5e56857

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

d286b18

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

ef9fe40

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

1f2ccec

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e1ec854

@jalvesz jalvesz deleted the to_num branch

June 10, 2025 09:45

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e5588ea

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

2aab9cc

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e0e5da5

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

47af29a

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

616f9f1

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e254745

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

5f60d44

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

c5360cb

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

cb6b4fb

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

d365f6b

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

5ff73d4

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

c18a7d8

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

a787dc7

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

58df720

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

2fa42b9

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

a58abc6

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

bbd166d

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

b3db782

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

0d89480

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e96fa9e

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

6d39684

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

7a67b2c

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

e1370b1

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

81a52da

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

548d6fb

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

ed2c3af

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

9e5aab7

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

9a60147

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

2b8d6b3

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

9ede94e

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

b82c2a1

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

3eb2412

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

4d88ec7

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

d6f47c3

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

8cf57ea

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

4b785d0

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

fd6af23

github-actions bot added a commit to banana-bred/stdlib that referenced this pull request

@github-actions


 fix current position of pointer ( fortran-lang#1000 )

7d253a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jalvesz @perazz @jvdp1