-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[webview_flutter_wkwebview] Fixes crash when running WKNavigationResponse tests on Xcode 26
#10316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WKNavigationResponse tests on Xcode 26 (追記ここまで)
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a crash that occurs during testing by introducing a singleton pattern for TestNavigationResponse. By using a static instance, it prevents premature deallocation of WKNavigationResponse objects within the test environment, which was causing the crash. The changes are correctly applied across the test files.
To align with the repository's contribution guidelines, please update the pull request title to include the package name (e.g., [webview_flutter_wkwebview] Fix crash in tests) and fill out the PR description with the necessary details, including the checklist and a link to the issue this PR resolves.
I have one suggestion to make the singleton implementation more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fully enforce the singleton pattern and prevent accidental creation of new TestNavigationResponse instances elsewhere in the tests, it's a good practice to make the initializer private. This will prevent reintroducing the deallocation crash in the future.
static let instance = TestNavigationResponse() private override init() { super.init() }
Uh oh!
There was an error while loading. Please reload this page.
Fixes flutter/flutter#173326
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1 .CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1 .///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3