-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[web_benchmarks] Report correct expected metrics for wasm #10236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue where expected metrics for Wasm benchmarks were incomplete. The change removes incorrect conditional logic, ensuring prerollFrame and applyFrame are always included. The useWasm parameter is now deprecated, which is a good cleanup. The package version and Flutter SDK constraints are also updated accordingly. I've found one minor issue in the CHANGELOG.md with a duplicate entry.
packages/web_benchmarks/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed since its obsoleted by the new line.
packages/web_benchmarks/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dart 3.10
packages/web_benchmarks/pubspec.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will fail unless these match.
Uh oh!
There was an error while loading. Please reload this page.
Depends on flutter/flutter@2e51c3f which will be part of the
3.38.0release.Fixes flutter/flutter#177057