Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix/saved filters l10n #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulleni merged 14 commits into main from fix/saved-filters-l10n
Oct 13, 2025
Merged

Fix/saved filters l10n #101

fulleni merged 14 commits into main from fix/saved-filters-l10n
Oct 13, 2025

Conversation

@fulleni
Copy link
Member

@fulleni fulleni commented Oct 13, 2025

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
 

- Replace "saved headlines" with "saved feed filters" in Arabic and English localization files
- Update descriptions to reflect the change from headlines to feed filters
- Rename `SavedHeadlinesFiltersLimitForm` to `SavedFeedFiltersLimitForm`
- Update import statement in `feed_configuration_tab.dart`
... SavedFeedFiltersLimitForm
- Update class name from SavedHeadlinesFiltersLimitForm to SavedFeedFiltersLimitForm
- Update related file name and comments
- Modify UI labels to reflect new form name
- Replace "saved headlines filter" with "saved feed filter" in Arabic and English localization files
- Update descriptions to reflect the new terminology
- Change 'savedHeadlinesFilterLimitsTitle' to 'savedFeedFilterLimitsTitle'
- Change 'savedHeadlinesFilterLimitsDescription' to 'savedFeedFilterLimitsDescription'
- Remove "Feed" references from the "User Content & Feed Limits" section
- Rename section title from "User Content & Feed Limits" to "User Content Limits"
- Update corresponding descriptions in both English and Arabic files
- Update translations to remove feed limits
- Rename section title from 'User Content & Feed Limits' to 'User Content Limits'
- Remove feed-related descriptions and comments
...tions
- Update Arabic and English labels and descriptions for saved feed filters limit
- Change "Saved Feed Filters Limit" to "Saved Filters Limit" for better clarity
- Update corresponding descriptions in both languages
- Update label from 'Saved Feed Filters Limit' to 'Saved Filters Limit'
- Adjust description to remove redundant wording
- Apply changes across main localization file and specific language files
Copy link

Summary of Changes

Hello @fulleni, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring effort to standardize the terminology used for saved filters within the application's configuration. The primary goal is to enhance user understanding and internal code consistency by replacing all instances of 'saved headlines filters' with 'saved feed filters'. This change encompasses updates to UI text, widget names, and comprehensive localization adjustments for both English and Arabic languages.

Highlights

  • Terminology Update: The term 'Saved Headlines Filters' has been consistently renamed to 'Saved Feed Filters' across the application for improved clarity and consistency.
  • Code Refactoring: The SavedHeadlinesFiltersLimitForm widget and its associated state and template comments have been refactored and renamed to SavedFeedFiltersLimitForm.
  • Localization Updates: All relevant localization keys and their corresponding English and Arabic translations have been updated to reflect the new 'Saved Feed Filters' terminology, including changes in app_localizations.dart, app_localizations_ar.dart, app_localizations_en.dart, and their respective ARB files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily involves refactoring and updating localization strings, renaming concepts from "saved headlines" to "saved feed filters". The changes are mostly well-executed and improve consistency. I've identified one high-severity bug where an incorrect localization key is used, and a couple of medium-severity issues related to maintainability, such as an outdated widget key and a documentation comment that was missed during the refactoring. Overall, good work on improving the codebase's clarity.

 

- Update Arabic translation for "savedFeedFilterLimitsTitle"
- Reorder English localization entries for better consistency
- Improve description for "savedFeedFilterLimitsDescription"
- Change "userContentLimitsTitle" from "حدود المحتوى للمستخدم" to "حدود المحتوى"
- Modify "savedFeedFiltersLimitLabel" from "حد المرشحات المحفوظة" to "حدود المرشحات"
- Change "Saved Filters Limit" to "Saved Filters Limits" for better grammatical agreement
- Update corresponding description for consistency
...aming
- Update localization key for saved feed filter limits tile
- Improve UI naming by changing "Filter Limits" to "Filters Limit"
@fulleni fulleni merged commit fe40951 into main Oct 13, 2025
1 check failed
@fulleni fulleni deleted the fix/saved-filters-l10n branch October 13, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /