-
Notifications
You must be signed in to change notification settings - Fork 0
Feat custom filters useres limits configuration #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat custom filters useres limits configuration #100
Conversation
- Replace git refs with version tags for auth-api, auth-client, auth-inmemory, auth-repository, core, data-api, data-client, data-inmemory, data-repository, http-client, kv-storage-service, kv-storage-shared-preferences, and ui-kit dependencies - Update package version to 1.0.0 - Remove publish_to field
- Create a new CHANGELOG.md file to document changes to the project
- Implement UserPresetLimitsForm widget for configuring user preset limits - Add fields for guest, authenticated, and premium user saved filters limits - Integrate with RemoteConfig and provide callback for config changes - Use TextFormFieldWithDescription for input fields with labels and descriptions
...ctory - Rename user_preset_limits_form.dart to lib/app_configuration/widgets/user_preset_limits_form.dart - This change improves the project structure and follows the recommended directory layout for Angular Dart applications
- Implement UserPresetsConfigurationTab widget - Add UserPresetLimitsForm to the tab for configuring user preset limits - Update dependencies to include core, flutter, ui_kit, and app_configuration packages
- Import UserPresetsConfigurationTab from new file - Increase TabController length from 3 to 4 - Add new tab for user presets in the tab bar - Implement UserPresetsConfigurationTab in the tab view
- Add Arabic and English translations for user presets tab and filter limit settings - Include new strings for user presets tab title, headlines filter preset limits, and saved filters limit description - Update existing translation files for both Arabic and English
- Change ExpansionTile title from 'userPresetLimitsTitle' to 'userPresetsTab'
- Update AR and EN ARB files to use the correct key for the description of saved headlines filters limit - Change 'savedFiltersLimitDescription' to 'savedHeadlinesFiltersLimitDescription' to match the context of headlines filters
...Widget - Implement TextEditingController for each input field - Add logic to handle updated widget configuration - Replace TextFormFieldWithDescription with AppConfigIntField - Update import statements and remove unused imports
...sion tiles - Add UserPresetLimitsForm widget to the feed configuration tab - Update existing expansion tiles indexing due to the new addition - Implement new expansion tile for user preset limits with appropriate localization and styling - Adjust spacing between expansion tiles
- Remove duplicate "userPresetsTab" and "savedHeadlinesFiltersLimitDescription" entries - Correct the order of "savedHeadlinesFiltersLimitDescription" and "adFrequencyDescription" entries
- Remove UserPresetsConfigurationTab widget - Remove user presets tab from AppConfigurationPage - Update tab controller length to 3
- Rename UserPresetLimitsForm to SavedHeadlinesFiltersLimitForm - Update widget documentation and comments - Change localization keys to be more specific to saved filters limits
...and naming - Rename 'UserPresetLimitsForm' to 'SavedHeadlinesFiltersLimitForm' - Update localization keys to use 'savedHeadlinesFilterLimits' instead of 'headlinesFilterPresetLimits' - Update ExpansionTile key and title to reflect the new naming
- Remove headlinesFilterPresetLimitsTitle and related entries - Remove savedHeadlinesFiltersLimitDescription - Add savedHeadlinesFilterLimitsTitle and related entries - Add guestSavedFiltersLimitLabel, standardUserSavedFiltersLimitLabel, and premiumUserSavedFiltersLimitLabel - Add savedFiltersLimitDescription
- Add description for User Content Limits section - Add description for Saved Headlines Filter Limits section - Update localizations to include new descriptions
- Remove unused localization strings for saved filters limits - Rename and update descriptions for saved headlines filter limits - Update Arabic and English localization files accordingly - Adjust ARB files to reflect changes in localization strings
...criptions - Replace guestSavedFiltersLimitLabel with savedHeadlinesFilterLimitsTitle - Replace standardUserSavedFiltersLimitLabel with savedHeadlinesFilterLimitsTitle - Replace premiumUserSavedFiltersLimitLabel with savedHeadlinesFilterLimitsTitle - Update description for all fields to use savedHeadlinesFilterLimitsTitle
- Remove the Text widget displaying the user content limits description - Remove the SizedBox for spacing below the description text
...aved headlines filters limit - Replace static form fields with a dynamic tabbed interface - Introduce TabController and map AppUserRole to tabs - Refactor TextEditingController implementation to use a map - Abstract logic for getting and updating saved filters limit by role - Improve code maintainability and extensibility for different user roles
...erLimitsTitle' - Update the Arabic translation from 'حدود تصفيات العناوين المحفوظة' to 'حدود مرشحات العناوين المحفوظة' - This change improves the accuracy of the translation, ensuring it correctly conveys the meaning of 'saved headlines filter limits'
- Removed redundant entry for version 1.0.0 in CHANGELOG.md - This change ensures the changelog contains unique and up-to-date information
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new feature that allows the configuration of custom limits for saved "headlines feed filters", differentiating these limits based on user roles (guest, standard, and premium). This enhancement provides greater control over user content capabilities within the application. Alongside this, the project's dependency management has been streamlined by migrating to semantic versioning for git-hosted packages, improving clarity and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature for configuring limits on saved "headlines feed filters", which is a valuable addition. The implementation includes a new form widget, UI changes to integrate it, and updates to localization files. The code is generally well-structured. I've provided a few suggestions to improve maintainability and efficiency, mainly concerning code duplication in the UI and redundant method calls in the new form widget's state management. Additionally, there's a minor formatting suggestion for the CHANGELOG.
Uh oh!
There was an error while loading. Please reload this page.
Status
READY
Description
This pull request implements a new feature that allows the configuration of custom limits for the saved "headlines feed filters", differentiating these limits based on user roles (guest, standard, and premium). This enhancement provides greater control over user content capabilities within the application. Alongside this, the project's dependency management has been streamlined by migrating to semantic versioning for git-hosted packages, improving clarity and maintainability.
Type of Change