Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Feat filter bookmarks saved entry handling #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulleni merged 8 commits into main from feat-filter-bookmarks-saved-entry-handling
Oct 13, 2025

Conversation

@fulleni
Copy link
Member

@fulleni fulleni commented Oct 13, 2025 •
edited
Loading

Status

READY

Description

This pull request enhances user customization by integrating a new savedFilters feature. It includes the necessary database schema updates and a migration to ensure backward compatibility for existing users. Furthermore, it refines the application's user preference management by introducing role-based limits for saved filters. The PR also tidies up dependency management by updating various package references to use semantic version tags, and establishes a changelog for future release tracking.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
 

- Update core from commit 828b984 to tag v1.2.0
- Update data-client, data-mongodb, data-repository, email-client,
 email-repository, and email-sendgrid from specific commits to tag v1.0.0
- Update http-client from commit 57f6bcf to tag v1.0.1
- Add savedFilters to the list of followedSources, followedTopics, and savedHeadlines in the defaultUserPreferences object
- This ensures that new user preferences will have an empty list for savedFilters by default
- Add savedFilters field to user_content_preferences collection
- Initialize savedFilters as an empty list for existing users
- Implement limit check for saved filters based on user account type
- Update existing limit logic to handle country, source, and topic items separately
- Add new Premium, Standard, and Guest limits for saved filters
- Add new migration class for adding saved filters to user preferences
- Update allMigrations list to include the new migration
- Create new migration to add 'savedFilters' field to existing user_content_preferences documents
- Set default value as an empty array for existing documents
- Implement 'up' method to add the field and 'down' method to remove it
- Add version 1.0.0 to pubspec.yaml for initial release
- Create CHANGELOG.md file with initial entry for 1.0.0 release
- Add date and description of the initial release under semantic versioning
@fulleni fulleni linked an issue Oct 13, 2025 that may be closed by this pull request
Copy link

Summary of Changes

Hello @fulleni, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances user customization by integrating a new savedFilters feature. It includes the necessary database schema updates and a migration to ensure backward compatibility for existing users. Furthermore, it refines the application's user preference management by introducing role-based limits for saved filters. The PR also tidies up dependency management by updating various package references to use semantic version tags, and establishes a changelog for future release tracking.

Highlights

  • Saved Filters Feature: Introduced a savedFilters field to user content preferences, allowing users to store filter configurations.
  • Database Migration: A new migration ensures that existing user preference documents are updated to include the savedFilters field, initialized as an empty array.
  • Preference Limit Enforcement: The user preference limit service now enforces limits on the number of saved filters a user can have, varying by account type (premium, standard, guest).
  • Dependency Versioning: Several project dependencies have been updated to reference specific semantic version tags (e.g., v1.2.0) instead of commit SHAs, improving dependency management clarity.
  • Initial Changelog: A CHANGELOG.md file has been added, marking the initial release of the project under semantic versioning.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality for saved filters, including a database migration and updates to enforce user limits. While the migration and data model changes are well-implemented, I've identified critical bugs in the limit enforcement logic in default_user_preference_limit_service.dart. Specifically, missing break statements in switch cases will cause incorrect limits to be applied to users. Additionally, the logic for guest users has not been fully updated to handle the new saved filters, creating an inconsistency. Please address these issues to ensure the feature works as intended.

@fulleni fulleni merged commit e0e01c7 into main Oct 13, 2025
1 check failed
@fulleni fulleni deleted the feat-filter-bookmarks-saved-entry-handling branch October 13, 2025 08:35
@fulleni fulleni added this to the Foundation Edition milestone Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: filter bookmarks saved entry handling

2 participants

AltStyle によって変換されたページ (->オリジナル) /