-
Couldn't load subscription status.
- Fork 0
Ci GitHub pages #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Rename workflow to "Deploy to GitHub Pages" - Add push trigger for main branch - Split workflow into build and deployment jobs - Add staging deployment for pushes to main - Retain production deployment for releases
- Set site URL to localhost for local development and GitHub Pages URL for CI - Use different base paths for release and staging environments - Add conditional logic based on process.env.CI and process.env.GITHUB_EVENT_NAME
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Astro configuration to support a more sophisticated CI/CD workflow for deploying documentation to GitHub Pages. By introducing dynamic site and base path settings, it ensures that the documentation builds correctly and is accessible at the appropriate URLs across local development, staging, and production environments.
Highlights
- Dynamic Site URL Configuration: The
siteconfiguration inastro.config.mjshas been updated to dynamically set the base URL. It now points to the GitHub Pages URL (https://flutter-news-app-full-source-code.github.io) when running in a CI environment, and tohttp://localhost:4321for local development. This ensures correct asset resolution and linking based on the deployment context. - Environment-Specific Base Path Configuration: The
baseconfiguration inastro.config.mjsis now conditional, allowing for different base paths depending on the build environment. For CI builds, it uses/docsif the GitHub event is arelease, and/docs-stagingfor other CI events (e.g., pull requests, main branch pushes). For local development, the base path is set to/. This enables distinct staging and production environments for the documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to configure the Astro build for different deployment environments. However, the changes introduce JavaScript syntax errors due to missing commas between object properties in astro.config.mjs. I've pointed out these critical issues and provided suggestions to fix them. Additionally, I've recommended a refactoring for the base path logic to improve its readability and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is also missing a trailing comma, which will cause a syntax error. While fixing it, you could also improve readability. The current nested ternary is hard to parse. Consider using an Immediately Invoked Function Expression (IIFE) to make the logic clearer.
base: (() => {
if (!process.env.CI) {
return '/';
}
if (process.env.GITHUB_EVENT_NAME === 'release') {
return '/docs';
}
return '/docs-staging';
})(),
No description provided.