-
Couldn't load subscription status.
- Fork 141
Add test for IPv6 functionality #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5cfd18 to
3e2c2e6
Compare
Apologies for the spam, my git is rusty and I haven't built on another PR previously!
Travis doesn't seem to support IPv6 (more info here and here ) so I did add a condition to skip in that case. Unfortunately this causes the IPv6 code to still not be covered through CI testing infrastructure - open to thoughts on how to address if this isn't workable.
kenhys
commented
Apr 22, 2021
@mcipperly could you rebase tihis pull request?
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
1bb0b39 to
4a30c09
Compare
@kenhys
kenhys
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to call _is_ipv4_host() in every _make_packet?
It may be able to reuse checked status.
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
6299ab9 to
291a76a
Compare
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Updated to address the above re: not wanting to determine v4/v6 capability each time. Now:
- When we connect, save address family
- If we fail to connect in the future, reset address family and try to figure it out again - this could address issues in long-running applications where the target fluent system loses its IPv4 or IPv6 address during runtime
Also added the prefer_ipv6 option which can be set to True to prefer IPv6 and fall back to IPv4
I wrote a test for PR #138 which adds IPv6 support ( #137 )