Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for firecracker snapshots #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CuriousGeorgiy wants to merge 2 commits into firecracker-microvm:main
base: main
Choose a base branch
Loading
from CuriousGeorgiy:vhive-integration

Conversation

@CuriousGeorgiy
Copy link

@CuriousGeorgiy CuriousGeorgiy commented Aug 22, 2023
edited
Loading

Description of changes:

In order to support firecracker snapshots we need to make the following
changes:

  • add a new CreateSnapshot request;
  • add new parameters for snapshot loading to the CreateVM request
    (following the firecracker Golang SDK design, snapshot loading is
    essentially creating a VM with additional snapshot options).

Also add a NetNS (network namespace) parameter to the CreateVM request,
since the current NetNS parameter nested in the JailerConfig parameter
requires specifying the entire jailer configuration, which is not
convenient.

Issue #, if available: #759

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pawelbeza reacted with heart emoji
The current network namespace parameter nested in the JailerConfig
parameter requires specifying the entire jailer configuration, which is not
convenient and doesn't allow using the noop jailer with a network
namespace.
To overcome this limitation, add a new NetNS parameter to the CreateVM
request.
See also a similar change in firecracker-microvm/firecracker-go-sdk#155.
Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
@CuriousGeorgiy CuriousGeorgiy force-pushed the vhive-integration branch 4 times, most recently from 09e74c6 to 9a7a2bd Compare September 8, 2023 11:39
In order to support firecracker snapshot-restore we need to make the
following changes:
* add a new CreateSnapshot request;
* add new parameters for snapshot loading to the CreateVM request
(following the firecracker Golang SDK design, snapshot loading is
essentially creating a VM with additional snapshot options).
When a VM is created by loading a snapshot, it's container snapshot drives
are already mounted, so the drive mount stub creation and mounting is
skipped.
Also add a NetNS (network namespace) parameter to the CreateVM request,
since the current NetNS parameter nested in the JailerConfig parameter
requires specifying the entire jailer configuration, which is not
convenient.
Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /